ZTS: Simplify zpool_initialize_verify_initialized #11328
Closed
+27
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The test is failing on FreeBSD.
Description
FreeBSD doesn't do
od -t x8 -Ad
. Instead of converting valuesbetween decimal and hex, let's just compare the decimal values.
Using a here-string to feed the loop in this test causes an empty
string to still trigger the loop so we miss the
spacemaps=0
case.Pipe into the loop instead.
Speaking of
spacemaps
, it's a confusing name for this counter sincewe're actually counting the number of metaslabs that don't have any
spacemaps. Change the naming to
metaslabs
instead.While here, we can use
zpool wait -t initialize $TESTPOOL
to wait forthe pool to initialize.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.