Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 5.10 compat: also zvol_revalidate_disk() #11358

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Linux 5.10 compat: also zvol_revalidate_disk() #11358

merged 1 commit into from
Dec 18, 2020

Conversation

veggiemike
Copy link
Contributor

@veggiemike veggiemike commented Dec 17, 2020 •
edited
Loading

Motivation and Context

Per discussion with @behlendorf while reviewing pull request #11348, added a commit to master that makes zvol_update_volsize() also call zvol_revalidate_disk() for 5.10 Linux kernel.

How Has This Been Tested?

Compiled on Ubuntu 18.04 against both 5.10 and 5.4 kernels.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@veggiemike
Linux 5.10 compat: also zvol_revalidate_disk()
cfccfb9 
Commit 59b6872 added a configure check for 5.10, which removed
revalidate_disk(), and conditionally replaced it's usage with a call to
the new revalidate_disk_size() function.  However, the old function also
invoked the device's registered callback, in our case
zvol_revalidate_disk().  This commit adds a call to zvol_revalidate_disk()
in zvol_update_volsize() to make sure the code path stays the same.

Signed-off-by: Michael D Labriola <michael.d.labriola@gmail.com>
@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 17, 2020
@behlendorf behlendorf merged commit 1c0bbd5 into openzfs:master Dec 18, 2020
behlendorf pushed a commit that referenced this pull request Dec 23, 2020
@veggiemike @behlendorf
Linux 5.10 compat: also zvol_revalidate_disk()
7a7e101 
Commit 59b6872 added a configure check for 5.10, which removed
revalidate_disk(), and conditionally replaced it's usage with a call to
the new revalidate_disk_size() function.  However, the old function also
invoked the device's registered callback, in our case
zvol_revalidate_disk().  This commit adds a call to zvol_revalidate_disk()
in zvol_update_volsize() to make sure the code path stays the same.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Michael D Labriola <michael.d.labriola@gmail.com>
Closes #11358
happyaron pushed a commit to happyaron/zfs that referenced this pull request Dec 29, 2020
@veggiemike @happyaron
Linux 5.10 compat: also zvol_revalidate_disk()
4bd18a1 
Commit 59b6872 added a configure check for 5.10, which removed
revalidate_disk(), and conditionally replaced it's usage with a call to
the new revalidate_disk_size() function.  However, the old function also
invoked the device's registered callback, in our case
zvol_revalidate_disk().  This commit adds a call to zvol_revalidate_disk()
in zvol_update_volsize() to make sure the code path stays the same.

Backported-by: Aron Xu <aron@debian.org>
Signed-off-by: Aron Xu <aron@debian.org>
Closes: openzfs#11358
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@veggiemike @jsai20
Linux 5.10 compat: also zvol_revalidate_disk()
bb45e35 
Commit 59b6872 added a configure check for 5.10, which removed
revalidate_disk(), and conditionally replaced it's usage with a call to
the new revalidate_disk_size() function.  However, the old function also
invoked the device's registered callback, in our case
zvol_revalidate_disk().  This commit adds a call to zvol_revalidate_disk()
in zvol_update_volsize() to make sure the code path stays the same.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Michael D Labriola <michael.d.labriola@gmail.com>
Closes openzfs#11358
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@veggiemike
Linux 5.10 compat: also zvol_revalidate_disk()
b86614f 
Commit 59b6872 added a configure check for 5.10, which removed
revalidate_disk(), and conditionally replaced it's usage with a call to
the new revalidate_disk_size() function.  However, the old function also
invoked the device's registered callback, in our case
zvol_revalidate_disk().  This commit adds a call to zvol_revalidate_disk()
in zvol_update_volsize() to make sure the code path stays the same.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Michael D Labriola <michael.d.labriola@gmail.com>
Closes openzfs#11358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veggiemike @behlendorf