Support uClibc for the tests compilations. #11600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Feb 16, 2021
behlendorf
added
Status: Accepted
behlendorf
reviewed
Feb 16, 2021
There are two issues that don't allow ZFS to be compiled using uClibc. `backtrace()`, and `program_invocation_short_name` as a `const`. This patch adds uClibc to the conditionals in the same way there are already for Glibc for `backtrace()`; and removes the external param `program_invocation_short_name` because its only used here for the whole project. Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com>
behlendorf
pushed a commit
that referenced
this pull request
Mar 5, 2021
There are two issues that don't allow ZFS to be compiled using uClibc. `backtrace()`, and `program_invocation_short_name` as a `const`. This patch adds uClibc to the conditionals in the same way there are already for Glibc for `backtrace()`; and removes the external param `program_invocation_short_name` because its only used here for the whole project. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com> Closes #11600
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
There are two issues that don't allow ZFS to be compiled using uClibc. `backtrace()`, and `program_invocation_short_name` as a `const`. This patch adds uClibc to the conditionals in the same way there are already for Glibc for `backtrace()`; and removes the external param `program_invocation_short_name` because its only used here for the whole project. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com> Closes openzfs#11600
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
There are two issues that don't allow ZFS to be compiled using uClibc. `backtrace()`, and `program_invocation_short_name` as a `const`. This patch adds uClibc to the conditionals in the same way there are already for Glibc for `backtrace()`; and removes the external param `program_invocation_short_name` because its only used here for the whole project. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: José Luis Salvador Rufo <salvador.joseluis@gmail.com> Closes openzfs#11600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues that don't allow ZFS to be compiled using uClibc.
backtrace(), andprogram_invocation_short_nameas aconst.This patch adds uClibc to the conditionals in the same way there are
already for Glibc for
backtrace(); and removes the external paramprogram_invocation_short_namebecause its only used here for thewhole project.
Signed-off-by: José Luis Salvador Rufo salvador.joseluis@gmail.com
Motivation and Context
I'm trying to add ZFS as a package into the Buildroot project.
Buildroot uses uClibc by default. This patch fix the compilation process of the tests.
I'm sending these changes to upstream in order to remove the .patch file (following
the Buildroot policies around patches).
How Has This Been Tested?
Compiling Buildroot with a first version patch from here:
https://patchwork.ozlabs.org/project/buildroot/patch/20210203075440.421072-1-salvador.joseluis@gmail.com/raw/
Using GLIBC, UCLIBC, and MUSL as toolchains.
Types of changes
Checklist:
Signed-off-by]