Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intentionally allow ZFS_READONLY in zfs_write #11693

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Intentionally allow ZFS_READONLY in zfs_write #11693

merged 1 commit into from
Mar 7, 2021

Commits on Mar 5, 2021

  1. Intentionally allow ZFS_READONLY in zfs_write 

    ZFS_READONLY represents the "DOS R/O" attribute.
When that flag is set, we should behave as if write access
were not granted by anything in the ACL.  In particular:
We _must_ allow writes after opening the file r/w, then
setting the DOS R/O attribute, and writing some more.
(Similar to how you can write after fchmod(fd, 0444).)

Restore these semantics which were lost on FreeBSD when refactoring
zfs_write.  To my knowledge Linux does not actually expose this flag,
but we'll need it to eventually so I've added the supporting checks.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
    Ryan Moeller authored and Ryan Moeller committed Mar 5, 2021
    Configuration menu
    Copy the full SHA
    47a3022 View commit details
    Browse the repository at this point in the history