Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: Fix scope of deadman tunables #11715

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 9, 2021

Motivation and Context

A couple of deadman tunables ended up in the wrong sysctl node.

Description

Move them to vfs.zfs.deadman.*, fix ZTS tunables.cfg where a couple other deadman tunables were misnamed as well.
I've intentionally left vfs.zfs.zio.deadman_log_all where it is, to not stray too far from the documented tunable names.

How Has This Been Tested?

Before:

$ sysctl vfs.zfs | grep deadman
vfs.zfs.deadman_enabled: 1
vfs.zfs.deadman_checktime_ms: 60000
vfs.zfs.zio.deadman_log_all: 0
vfs.zfs.deadman.ziotime_ms: 300000
vfs.zfs.deadman.synctime_ms: 600000
vfs.zfs.deadman.failmode: wait

After:

$ sysctl vfs.zfs | grep deadman
vfs.zfs.zio.deadman_log_all: 0
vfs.zfs.deadman.ziotime_ms: 300000
vfs.zfs.deadman.synctime_ms: 600000
vfs.zfs.deadman.failmode: wait
vfs.zfs.deadman.enabled: 1
vfs.zfs.deadman.checktime_ms: 60000

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost added the Status: Code Review Needed Ready for review and testing label Mar 9, 2021
@ghost ghost requested a review from amotin March 9, 2021 14:22
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a creating new consistency rather than restoring previous one. I'd probably just restore the previous, but I don't insist. I am OK with any way, but would be good to have a wider look to see what is better.

@behlendorf behlendorf merged commit 35aa9dc into openzfs:master Mar 12, 2021
@ghost ghost deleted the deadman-tunables branch March 12, 2021 10:23
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11715
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11715
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11715
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11715
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11715
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11715
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11715
behlendorf pushed a commit that referenced this pull request May 20, 2021
A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #11715
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11715
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
A few deadman tunables ended up in the wrong sysctl node.

Move them to vfs.zfs.deadman.*

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #11715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants