Linux 5.12 update: bio_max_segs() replaces BIO_MAX_PAGES #11765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
behlendorf
approved these changes
Mar 17, 2021
|
FYI - since this commit modifies |
tonyhutter
approved these changes
Mar 17, 2021
behlendorf
added
Status: Accepted
The BIO_MAX_PAGES macro is being retired in favor of a bio_max_segs() function that implements the typical MIN(x,y) logic used throughout the kernel for bounding the allocation, and also the new implementation is intended to be signed-safe (which the former was not). Signed-off-by: Coleman Kane <ckane@colemankane.org>
ckane
force-pushed
the
linux-5.12-bio_max_segs
branch
from
407ec39 to
0e3046c
Compare
|
Updated with a clean rebase against latest |
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The BIO_MAX_PAGES macro is being retired in favor of a bio_max_segs() function that implements the typical MIN(x,y) logic used throughout the kernel for bounding the allocation, and also the new implementation is intended to be signed-safe (which the former was not). Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11765
adamdmoss
pushed a commit
to adamdmoss/zfs
that referenced
this pull request
Apr 10, 2021
The BIO_MAX_PAGES macro is being retired in favor of a bio_max_segs() function that implements the typical MIN(x,y) logic used throughout the kernel for bounding the allocation, and also the new implementation is intended to be signed-safe (which the former was not). Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11765
behlendorf
pushed a commit
that referenced
this pull request
May 20, 2021
The BIO_MAX_PAGES macro is being retired in favor of a bio_max_segs() function that implements the typical MIN(x,y) logic used throughout the kernel for bounding the allocation, and also the new implementation is intended to be signed-safe (which the former was not). Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes #11765 (cherry picked from commit ffd6978) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev>
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
The BIO_MAX_PAGES macro is being retired in favor of a bio_max_segs() function that implements the typical MIN(x,y) logic used throughout the kernel for bounding the allocation, and also the new implementation is intended to be signed-safe (which the former was not). Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11765
tonyhutter
pushed a commit
that referenced
this pull request
Jun 23, 2021
The BIO_MAX_PAGES macro is being retired in favor of a bio_max_segs() function that implements the typical MIN(x,y) logic used throughout the kernel for bounding the allocation, and also the new implementation is intended to be signed-safe (which the former was not). Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes #11765 (cherry picked from commit ffd6978) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev>
veggiemike
pushed a commit
to veggiemike/zfs
that referenced
this pull request
Sep 6, 2021
The BIO_MAX_PAGES macro is being retired in favor of a bio_max_segs() function that implements the typical MIN(x,y) logic used throughout the kernel for bounding the allocation, and also the new implementation is intended to be signed-safe (which the former was not). Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11765 (cherry picked from commit ffd6978) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BIO_MAX_PAGES macro is being retired in favor of a bio_max_segs()
function that implements the typical MIN(x,y) logic used throughout the
kernel for bounding the allocation, and also the new implementation is
intended to be signed-safe (which the former was not).
Signed-off-by: Coleman Kane ckane@colemankane.org
Description, Motivation, and Context
The
BIO_MAX_PAGESmacro has been superseded by a newbio_max_segs()inline function that performs the tests for which it was intended in a more concise and mathematically correct way. The former macro was removed, and this broke the build. This commit fixes that problem by testing for the existence of the newbio_max_segs()API, and preferring it, where it exists.How Has This Been Tested?
I have been running this change on Linux 5.12rc3 on my daily use personal system with ZFS root.
Types of changes
Checklist:
Signed-off-by.