Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD: Fix memory leaks in kstats #11767

Merged
merged 1 commit into from
Mar 18, 2021
Merged

FreeBSD: Fix memory leaks in kstats #11767

merged 1 commit into from
Mar 18, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2021 •
edited by ghost
Loading

Motivation and Context

When unloading the openzfs module after some use on FreeBSD, a message like the following could be observed in dmesg:

Warning: memory type solaris leaked memory on destroy (16 allocations, 2048 bytes leaked).

The numbers varied depending on what you were doing with ZFS.

Description

Free the data allocated for non-virtual kstats when deleting the object.

While here, eliminate some incorrect and pointless handling of kmem_zalloc returning NULL.
It won't return NULL because we used KM_SLEEP.

How Has This Been Tested?

Ran a known workload (history_001) before and after the change, observing dmesg to see the leak is gone.
Ran many iterations of ZTS on FreeBSD to verify stability.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost ghost added the Status: Code Review Needed Ready for review and testing label Mar 17, 2021
@ghost ghost requested a review from amotin March 17, 2021 21:27
FreeBSD: Fix memory leaks in kstats
a184921 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost force-pushed the testing/leaky-kstat branch from 415e1b4 to a184921 Compare March 17, 2021 22:10
@ghost
Copy link
Author

ghost commented Mar 17, 2021

  • Removed incorrect and pointless malloc failure handling

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 18, 2021
@behlendorf behlendorf merged commit ec3e4c6 into openzfs:master Mar 18, 2021
@ghost ghost deleted the testing/leaky-kstat branch March 18, 2021 10:43
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@jsai20
FreeBSD: Fix memory leaks in kstats
8d6d202 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11767
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
@adamdmoss
FreeBSD: Fix memory leaks in kstats
b42720a 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11767
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
FreeBSD: Fix memory leaks in kstats
1880799 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11767
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
FreeBSD: Fix memory leaks in kstats
15cc429 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11767
ghost pushed a commit to truenas/zfs that referenced this pull request May 7, 2021
FreeBSD: Fix memory leaks in kstats
1fe3892 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11767
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
FreeBSD: Fix memory leaks in kstats
827f649 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11767
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
FreeBSD: Fix memory leaks in kstats
534344b 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11767
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
FreeBSD: Fix memory leaks in kstats
946734f 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11767
ghost pushed a commit to truenas/zfs that referenced this pull request May 13, 2021
FreeBSD: Fix memory leaks in kstats
fce7cb2 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11767
behlendorf pushed a commit that referenced this pull request May 20, 2021
@behlendorf
FreeBSD: Fix memory leaks in kstats
911a095 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #11767
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
FreeBSD: Fix memory leaks in kstats
9dafa3d 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#11767
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@tonyhutter
FreeBSD: Fix memory leaks in kstats
825d8e1 
Don't handle (incorrectly) kmem_zalloc() failure.  With KM_SLEEP,
will never return NULL.

Free the data allocated for non-virtual kstats when deleting the object.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #11767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @amotin