Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running FreeBSD buildworld on Arm-based macOS hosts #11771

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

jrtc27
Copy link
Contributor

@jrtc27 jrtc27 commented Mar 20, 2021

Motivation and Context

Arm-based Macs are like FreeBSD and provide a full 64-bit stat from the start, so have no stat64 variants.

Description

Define stat64 and fstat64 as aliases for the normal versions.

How Has This Been Tested?

FreeBSD buildworld succeeds with this patch applied to the vendored OpenZFS code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Arm-based Macs are like FreeBSD and provide a full 64-bit stat from the
start, so have no stat64 variants. Thus, define stat64 and fstat64 as
aliases for the normal versions.

Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
@ghost ghost added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 20, 2021
@behlendorf behlendorf merged commit ef977fc into openzfs:master Mar 26, 2021
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
Arm-based Macs are like FreeBSD and provide a full 64-bit stat from the
start, so have no stat64 variants. Thus, define stat64 and fstat64 as
aliases for the normal versions.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Closes openzfs#11771
@jrtc27 jrtc27 deleted the macos-arm branch April 22, 2021 15:12
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Arm-based Macs are like FreeBSD and provide a full 64-bit stat from the
start, so have no stat64 variants. Thus, define stat64 and fstat64 as
aliases for the normal versions.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Closes openzfs#11771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants