Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs get -p only outputs 3 columns if "clones" property is empty #11837

Merged
merged 1 commit into from
Apr 6, 2021
Merged

zfs get -p only outputs 3 columns if "clones" property is empty #11837

merged 1 commit into from
Apr 6, 2021

Conversation

matt-fidd
Copy link
Contributor

@matt-fidd matt-fidd commented Apr 3, 2021 •
edited
Loading

Motivation and Context

get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable zfs get output as
only three columns are output, instead of 4.

How Has This Been Tested?

This is an upstream from the same change against illumos, where the test suite has been run and is passing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@matt-fidd
zfs get -p only outputs 3 columns if "clones" property is empty
4403b06 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
behlendorf
behlendorf approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Apr 6, 2021
@behlendorf behlendorf merged commit a03b288 into openzfs:master Apr 6, 2021
behlendorf pushed a commit that referenced this pull request Apr 7, 2021
@matt-fidd @behlendorf
zfs get -p only outputs 3 columns if "clones" property is empty
1bb4b5a 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes #11837
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Apr 9, 2021
@matt-fidd @mcmilk
zfs get -p only outputs 3 columns if "clones" property is empty
40026e1 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Apr 9, 2021
@matt-fidd @mcmilk
zfs get -p only outputs 3 columns if "clones" property is empty
9cd95a8 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
@matt-fidd @adamdmoss
zfs get -p only outputs 3 columns if "clones" property is empty
77ebe62 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@matt-fidd
zfs get -p only outputs 3 columns if "clones" property is empty
160c439 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@matt-fidd
zfs get -p only outputs 3 columns if "clones" property is empty
5dd0756 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@matt-fidd
zfs get -p only outputs 3 columns if "clones" property is empty
1566457 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
ghost pushed a commit to truenas/zfs that referenced this pull request May 7, 2021
@matt-fidd
zfs get -p only outputs 3 columns if "clones" property is empty
40ffe0f 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@matt-fidd
zfs get -p only outputs 3 columns if "clones" property is empty
0a37912 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@matt-fidd
zfs get -p only outputs 3 columns if "clones" property is empty
d4d2f6c 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@matt-fidd
zfs get -p only outputs 3 columns if "clones" property is empty
73c2f61 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
ghost pushed a commit to truenas/zfs that referenced this pull request May 13, 2021
@matt-fidd
zfs get -p only outputs 3 columns if "clones" property is empty
29f86c1 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
behlendorf pushed a commit that referenced this pull request May 20, 2021
@matt-fidd @behlendorf
zfs get -p only outputs 3 columns if "clones" property is empty
b9a5e3a 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes #11837
@matt-fidd matt-fidd deleted the get-clones branch May 20, 2021 23:46
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@matt-fidd
zfs get -p only outputs 3 columns if "clones" property is empty
df19717 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes openzfs#11837
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@matt-fidd @tonyhutter
zfs get -p only outputs 3 columns if "clones" property is empty
932d471 
get_clones_string currently returns an empty string for filesystem
snapshots which have no clones. This breaks parsable `zfs get` output as
only three columns are output, instead of 4.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Fiddaman <github@m.fiddaman.uk>
Co-authored-by: matt <matt@fiddaman.net>
Closes #11837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-fidd @behlendorf