Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for broken alien version #11850

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Conversation

rincebrain
Copy link
Contributor

Implemented the suggested detection of a broken alien version from #11848

Motivation and Context

Closes #11848 ; does not fix #11650, merely detects the broken version discovered from that.

Description

Added a check for alien 8.95.3, which is known to fail to generate debs 100% of the time, and instead print out a message informing the developer that it's known to be broken and linking them to more information.

How Has This Been Tested?

Tried compiling with alien 8.95 and 8.95.3 installed, verified that it bailed out on the latter and built normally with the former.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
@behlendorf
Copy link
Contributor

Just to be clear do I understand correctly that only this version of alien is effected? Both older and newer versions work fine? It would be best if we could make sure Debian bullsye ships with a working version, even if we do expect most users to use the distribution provided packages and not alien. @aerusso do you happen to know if getting a newer (or even older) version is still possible? Regardless, adding a warning does seem like the least we can do.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 7, 2021
@rincebrain
Copy link
Contributor Author

rincebrain commented Apr 7, 2021

Technically, 8.95.2 and 8.95.1 are also affected by at least one of the two bugs, but nobody's shipped those in a released distro that I could find, so I didn't make the check more versatile. It'd be simple enough to do if you'd prefer.

There's not yet any version newer than 8.95.3; one presumes they would ship patches for this in that version, but it's not been cut yet, so who knows.

You have to go out of your way to get 8.95 on bullseye - I think your options are grabbing the buster packages for it or building it yourself. There's not really an easy way to just go "apt install alien-8.95" without some work on your part.

quick edit: the same commit actually caused both bugs, so 8.95.1 and 8.95.2 have both problems as well.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
@behlendorf
Copy link
Contributor

Once Debian bullseye is available we'll want to add it to the CI and that looks like it's going to be an issue unless this is resolved in the distribution. Is there either a Debian or alien bug we can reference for this? This might also be a good time to revisit adding some proper deb style packaging in the repository as long it doesn't conflict with the downstream packaging.

@ghost
Copy link

ghost commented Apr 7, 2021

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985835

Awesome, looks like someone is on it as of today.

@behlendorf
Copy link
Contributor

That's good news. It sounds like we'll probably want to include this change either way but it'll be nice if this can get resolved before it's a wide spread issue.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 7, 2021
@behlendorf behlendorf merged commit 46fb478 into openzfs:master Apr 8, 2021
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Apr 10, 2021
Added a check for alien 8.95.{1,2,3}, which is known to fail to 
generate debs 100% of the time, and instead print out a message 
informing the developer that it's known to be broken and linking 
them to more information.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#11848 
Closes openzfs#11850
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
Added a check for alien 8.95.{1,2,3}, which is known to fail to 
generate debs 100% of the time, and instead print out a message 
informing the developer that it's known to be broken and linking 
them to more information.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#11848 
Closes openzfs#11850
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Apr 10, 2021
Added a check for alien 8.95.{1,2,3}, which is known to fail to 
generate debs 100% of the time, and instead print out a message 
informing the developer that it's known to be broken and linking 
them to more information.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#11848 
Closes openzfs#11850
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 14, 2021
Added a check for alien 8.95.{1,2,3}, which is known to fail to 
generate debs 100% of the time, and instead print out a message 
informing the developer that it's known to be broken and linking 
them to more information.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#11848 
Closes openzfs#11850
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Added a check for alien 8.95.{1,2,3}, which is known to fail to 
generate debs 100% of the time, and instead print out a message 
informing the developer that it's known to be broken and linking 
them to more information.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#11848 
Closes openzfs#11850
@rincebrain rincebrain deleted the 11848 branch October 23, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a warning for certain alien versions? Debian 11 Source DKMS Build Fails Due to 'alien' and 'dh'
2 participants