Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kmod-zfs should obsolete kmod-spl as well as spl-kmod #11865

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

ofaaland
Copy link
Contributor

@ofaaland ofaaland commented Apr 8, 2021

Motivation and Context

OS: RHEL 7.9
zfs version: master as of commit 9c3b926
packages built using --with-spec=redhat

Without this Obsoletes, an upgrade from zfs-0.7 to zfs-2.x
does not cause the kmod-spl-0.7 package to be removed.

Description

Add Obsoletes: kmod-spl to the zfs-kmod preamble.

How Has This Been Tested?

Installed zfs-0.7 packages.
Built new packages locally with this commit and installed via rpm -Uvh *.rpm

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Without this Obsoletes, using packages built --with-spec=redhat, an
upgrade from zfs-0.7 to zfs-2.x does not cause the kmod-spl-0.7 package
to be removed.

Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
@ofaaland ofaaland force-pushed the b-obsolete-kmod-spl branch from cb02a1e to 614a755 Compare April 8, 2021 21:05
@behlendorf behlendorf added the Component: Packaging custom packages label Apr 8, 2021
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Apr 9, 2021
@behlendorf behlendorf merged commit 2ec0b0d into openzfs:master Apr 11, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 14, 2021
Without this Obsoletes, using packages built --with-spec=redhat, an
upgrade from zfs-0.7 to zfs-2.x does not cause the kmod-spl-0.7 package
to be removed.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Closes openzfs#11865
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Without this Obsoletes, using packages built --with-spec=redhat, an
upgrade from zfs-0.7 to zfs-2.x does not cause the kmod-spl-0.7 package
to be removed.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Closes openzfs#11865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Packaging custom packages Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants