Balance parentheses in parameter descriptions #11882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Paweł Stefaniak <pstef@freebsd.org>
behlendorf
approved these changes
Apr 11, 2021
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Apr 14, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Piotr Paweł Stefaniak <pstef@freebsd.org> Closes openzfs#11882
mcmilk
pushed a commit
to mcmilk/zfs
that referenced
this pull request
Apr 15, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Piotr Paweł Stefaniak <pstef@freebsd.org> Closes openzfs#11882
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 6, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Piotr Paweł Stefaniak <pstef@freebsd.org> Closes openzfs#11882
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 6, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Piotr Paweł Stefaniak <pstef@freebsd.org> Closes openzfs#11882
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 6, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Piotr Paweł Stefaniak <pstef@freebsd.org> Closes openzfs#11882
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 7, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Piotr Paweł Stefaniak <pstef@freebsd.org> Closes openzfs#11882
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Piotr Paweł Stefaniak <pstef@freebsd.org> Closes openzfs#11882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Two parameter descriptions have unbalanced parentheses. unflushed_max_mem_ppm just has a missed closing paren:
Percentage of the overall system memory that ZFS allows to be used for unflushed changes (value is calculated over 1000000 for finer granularityand load_verify_shift is
log2(fraction of arc that can be used by inflight I/Os when verifying pool during importwhich seems to be a mistake from copying fromlog2(fraction of arc to reclaim)Description
Remove the surplus paren from load_verify_shift's description and add the missing one to unflushed_max_mem_ppm's description.
How Has This Been Tested?
I haven't tested this.
Types of changes
Checklist:
Signed-off-by.