Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vdev health padding in zpool list -v #11899

Merged
merged 1 commit into from Apr 14, 2021
Merged

Fix vdev health padding in zpool list -v #11899

merged 1 commit into from Apr 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2021

Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Signed-off-by: Yuri Pankov yuripv@FreeBSD.org

Motivation and Context

Per-vdev health in zpool list -v is padded inconsistently.

Description

Don't pad (incorrectly at that) the health value separately, it will be properly padded when printing.

How Has This Been Tested?

Before:

$ zpool list -v
NAME         SIZE  ALLOC   FREE  CKPOINT  EXPANDSZ   FRAG    CAP  DEDUP    HEALTH  ALTROOT
data        14.5T  12.4G  14.5T        -         -     0%     0%  1.00x    ONLINE  -
  raidz1    14.5T  12.4G  14.5T        -         -     0%  0.08%      -  ONLINE
    ada1p1      -      -      -        -         -      -      -      -  ONLINE
    ada2p1      -      -      -        -         -      -      -      -  ONLINE
    ada3p1      -      -      -        -         -      -      -      -  ONLINE
    ada4p1      -      -      -        -         -      -      -      -  ONLINE
system       672G  12.2G   660G        -         -     0%     1%  1.00x    ONLINE  -
  ada0p3     672G  12.2G   660G        -         -     0%  1.81%      -  ONLINE

After:

$ zpool list -v
NAME         SIZE  ALLOC   FREE  CKPOINT  EXPANDSZ   FRAG    CAP  DEDUP    HEALTH  ALTROOT
data        14.5T  12.4G  14.5T        -         -     0%     0%  1.00x    ONLINE  -
  raidz1    14.5T  12.4G  14.5T        -         -     0%  0.08%      -    ONLINE
    ada1p1      -      -      -        -         -      -      -      -    ONLINE
    ada2p1      -      -      -        -         -      -      -      -    ONLINE
    ada3p1      -      -      -        -         -      -      -      -    ONLINE
    ada4p1      -      -      -        -         -      -      -      -    ONLINE
system       672G  12.2G   660G        -         -     0%     1%  1.00x    ONLINE  -
  ada0p3     672G  12.2G   660G        -         -     0%  1.81%      -    ONLINE

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Fix vdev health padding in zpool list -v
d8020ce 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 13, 2021
@ghost ghost added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 14, 2021
@behlendorf behlendorf merged commit 96904d8 into openzfs:master Apr 14, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 14, 2021
@behlendorf
Fix vdev health padding in zpool list -v
7bf3959 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Apr 15, 2021
@mcmilk
Fix vdev health padding in zpool list -v
ea4f5b4 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
Fix vdev health padding in zpool list -v
51b85f2 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
Fix vdev health padding in zpool list -v
68375f6 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
Fix vdev health padding in zpool list -v
ad3814b 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
ghost pushed a commit to truenas/zfs that referenced this pull request May 7, 2021
Fix vdev health padding in zpool list -v
9e11689 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
Fix vdev health padding in zpool list -v
3660d39 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
Fix vdev health padding in zpool list -v
91d439f 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
Fix vdev health padding in zpool list -v
96a89fc 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
ghost pushed a commit to truenas/zfs that referenced this pull request May 13, 2021
Fix vdev health padding in zpool list -v
d7dba07 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
behlendorf pushed a commit that referenced this pull request May 20, 2021
@behlendorf
Fix vdev health padding in zpool list -v
9fcc2e7 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes #11899
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Fix vdev health padding in zpool list -v
1fb05a5 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes openzfs#11899
@behlendorf behlendorf mentioned this pull request Jun 8, 2021
Closed
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@tonyhutter
Fix vdev health padding in zpool list -v
e69f73c 
Do not (incorrectly, right instead left) pad health string itself,
it will be taken care of when printing property value below.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Yuri Pankov <yuripv@FreeBSD.org>
Closes #11899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@behlendorf