Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: Prune some unneeded definitions #11973

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2021

Motivation and Context

IS_XATTRDIR is never used.
v_count is only used in two places, one immediately followed by the use of
the real name, v_usecount.

Description

Remove the unneeded definitions, update one use of v_count in code.

How Has This Been Tested?

TODO

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost ghost added the Status: Code Review Needed Ready for review and testing label Apr 29, 2021
IS_XATTRDIR is never used.
v_count is only used in two places, one immediately followed by the
use of the real name, v_usecount.

Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
@ghost ghost force-pushed the bsd-module-cleanup branch from 80f7d8c to f4cbd7f Compare April 29, 2021 20:00
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 29, 2021
@behlendorf behlendorf merged commit 801c761 into openzfs:master Apr 30, 2021
@ghost ghost deleted the bsd-module-cleanup branch April 30, 2021 15:01
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
IS_XATTRDIR is never used.
v_count is only used in two places, one immediately followed by the
use of the real name, v_usecount.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#11973
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
IS_XATTRDIR is never used.
v_count is only used in two places, one immediately followed by the
use of the real name, v_usecount.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#11973
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
IS_XATTRDIR is never used.
v_count is only used in two places, one immediately followed by the
use of the real name, v_usecount.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#11973
ghost pushed a commit to truenas/zfs that referenced this pull request May 7, 2021
IS_XATTRDIR is never used.
v_count is only used in two places, one immediately followed by the
use of the real name, v_usecount.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#11973
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 10, 2021
IS_XATTRDIR is never used.
v_count is only used in two places, one immediately followed by the
use of the real name, v_usecount.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#11973
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
IS_XATTRDIR is never used.
v_count is only used in two places, one immediately followed by the
use of the real name, v_usecount.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
Closes openzfs#11973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant