Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated zfs_dbgmsg_enable documentation to be more accurate. #11986

Merged
merged 1 commit into from
May 6, 2021

Conversation

rincebrain
Copy link
Contributor

@rincebrain rincebrain commented May 1, 2021

Motivation and Context

#11984

Description

Changed the default specified for zfs_dbgmsg_enable, added clarification of interaction with zfs_flags.

(If people think that instead the default should be changed, that can be done too.)

How Has This Been Tested?

man man/man5/zfs-module-parameters.5 didn't produce any errors, make checkstyle didn't either.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost ghost added Status: Code Review Needed Ready for review and testing Type: Documentation Indicates a requested change to the documentation labels May 4, 2021
@ghost
Copy link

ghost commented May 4, 2021

You could bump the date on the man page, too.

Changed the default specified for zfs_dbgmsg_enable, added
clarification of interaction with zfs_flags.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#11984
@behlendorf behlendorf merged commit 1f77b58 into openzfs:master May 6, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 10, 2021
Changed the default specified for zfs_dbgmsg_enable, added
clarification of interaction with zfs_flags.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#11984
Closes openzfs#11986
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Changed the default specified for zfs_dbgmsg_enable, added
clarification of interaction with zfs_flags.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#11984
Closes openzfs#11986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing Type: Documentation Indicates a requested change to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants