Add Pushover notifier. #12012
Merged
Add Pushover notifier. #12012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scolby33
force-pushed
the
pushover_notifier
branch
from
283864f to
53d45f3
Compare
|
Oh, looks like the pipeline uses an older version of shellcheck. I'll put the old ignore back later tomorrow morning. |
Yes, we're still using the shellcheck from Ubuntu 18.04. |
Add zed_notify_pushover to zed-functions.sh, along with the necessary configuration variables in zed.rc. Signed-off-by: Scott Colby <scott@scolby.com>
scolby33
force-pushed
the
pushover_notifier
branch
from
53d45f3 to
60e1eee
Compare
Fixed! |
behlendorf
approved these changes
May 13, 2021
behlendorf
added
Status: Accepted
rincebrain
pushed a commit
to rincebrain/zfs
that referenced
this pull request
May 17, 2021
Add zed_notify_pushover to zed-functions.sh, along with the necessary configuration variables in zed.rc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Signed-off-by: Scott Colby <scott@scolby.com> Closes openzfs#12012
rincebrain
pushed a commit
to rincebrain/zfs
that referenced
this pull request
May 17, 2021
Add zed_notify_pushover to zed-functions.sh, along with the necessary configuration variables in zed.rc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Signed-off-by: Scott Colby <scott@scolby.com> Closes openzfs#12012
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Feb 10, 2022
Add zed_notify_pushover to zed-functions.sh, along with the necessary configuration variables in zed.rc. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Signed-off-by: Scott Colby <scott@scolby.com> Closes openzfs#12012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Pushover notifications to
zed-functions.sh.Motivation and Context
I would like to receive Pushover notifications from my zedlets.
Description
I have created a
zed_notify_pushoverfunction similar to the other notification functions.I have also added the appropriate configuration values, commented out, to
zed.rc.How Has This Been Tested?
I have been using this code by manually patching my local copy of
zed-functions.shin production for about 5 months.Additionally, it is a very close analogue to the existing notification functions.
I am happy to do additional testing if it is desired.
Types of changes
Checklist:
Signed-off-by.