Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: Increase redundancy test timeout #12043

Merged
merged 1 commit into from
May 14, 2021

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Example of the CI hitting the timeout.

http://build.zfsonlinux.org/builders/FreeBSD%20stable%2F12%20amd64%20%28TEST%29/builds/5137/steps/shell_4/logs/summary

Description

The redundancy_draid.ksh and redundancy_raidz.ksh tests were updated
by commit 93c8e91 to additionally verify self-healing. This
additional check increased the run time which can now occasionally
exceed the default maximum timeout in the CI environment. To prevent
this from causing failures increase the default timeout for the
redundancy test cases.

How Has This Been Tested?

Manually inspected. We'll want to check the run times in the CI which
are often close to hitting this timeout. Speeding up the test case itself
wouldn't be a bad idea either.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

The redundancy_draid.ksh and redundancy_raidz.ksh tests were updated
by commit 93c8e91 to additionally verify self-healing.  This
additional check increased the run time which can now occasionally
exceed the default maximum timeout in the CI environment.  To prevent
this from causing failures increase the default timeout for the
redundancy test cases.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 14, 2021
@behlendorf behlendorf requested a review from jwk404 May 14, 2021 04:43
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 14, 2021
@behlendorf behlendorf merged commit 6a13add into openzfs:master May 14, 2021
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request May 17, 2021
The redundancy_draid.ksh and redundancy_raidz.ksh tests were updated
by commit 93c8e91 to additionally verify self-healing.  This
additional check increased the run time which can now occasionally
exceed the default maximum timeout in the CI environment.  To prevent
this from causing failures increase the default timeout for the
redundancy test cases.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12043
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request May 17, 2021
The redundancy_draid.ksh and redundancy_raidz.ksh tests were updated
by commit 93c8e91 to additionally verify self-healing.  This
additional check increased the run time which can now occasionally
exceed the default maximum timeout in the CI environment.  To prevent
this from causing failures increase the default timeout for the
redundancy test cases.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12043
behlendorf added a commit to behlendorf/zfs that referenced this pull request May 28, 2021
The redundancy_draid.ksh and redundancy_raidz.ksh tests were updated
by commit 93c8e91 to additionally verify self-healing.  This
additional check increased the run time which can now occasionally
exceed the default maximum timeout in the CI environment.  To prevent
this from causing failures increase the default timeout for the
redundancy test cases.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12043
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
The redundancy_draid.ksh and redundancy_raidz.ksh tests were updated
by commit 93c8e91 to additionally verify self-healing.  This
additional check increased the run time which can now occasionally
exceed the default maximum timeout in the CI environment.  To prevent
this from causing failures increase the default timeout for the
redundancy test cases.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#12043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants