Bend zpl_set_acl to permit the new userns* parameter. #12093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
reviewed
May 21, 2021
rincebrain
force-pushed
the
12076
branch
2 times, most recently
from
8cb4221 to
d48f1cd
Compare
behlendorf
requested changes
May 26, 2021
Just like openzfs#12087, the set_acl signature changed with all the bolted-on *userns parameters, which disabled set_acl usage, and caused openzfs#12076. Turn zpl_set_acl into zpl_set_acl and zpl_set_acl_impl, and add a new configure test for the new version. Closes: openzfs#12076 Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
behlendorf
approved these changes
May 26, 2021
behlendorf
added
Status: Accepted
BtbN
pushed a commit
to BtbN/zfs
that referenced
this pull request
May 27, 2021
Just like openzfs#12087, the set_acl signature changed with all the bolted-on *userns parameters, which disabled set_acl usage, and caused openzfs#12076. Turn zpl_set_acl into zpl_set_acl and zpl_set_acl_impl, and add a new configure test for the new version. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#12076 Closes openzfs#12093
BtbN
pushed a commit
to BtbN/zfs
that referenced
this pull request
May 27, 2021
Just like openzfs#12087, the set_acl signature changed with all the bolted-on *userns parameters, which disabled set_acl usage, and caused openzfs#12076. Turn zpl_set_acl into zpl_set_acl and zpl_set_acl_impl, and add a new configure test for the new version. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#12076 Closes openzfs#12093
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
May 28, 2021
Just like openzfs#12087, the set_acl signature changed with all the bolted-on *userns parameters, which disabled set_acl usage, and caused openzfs#12076. Turn zpl_set_acl into zpl_set_acl and zpl_set_acl_impl, and add a new configure test for the new version. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#12076 Closes openzfs#12093
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Just like openzfs#12087, the set_acl signature changed with all the bolted-on *userns parameters, which disabled set_acl usage, and caused openzfs#12076. Turn zpl_set_acl into zpl_set_acl and zpl_set_acl_impl, and add a new configure test for the new version. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#12076 Closes openzfs#12093
tonyhutter
pushed a commit
that referenced
this pull request
Jun 1, 2021
Just like #12087, the set_acl signature changed with all the bolted-on *userns parameters, which disabled set_acl usage, and caused #12076. Turn zpl_set_acl into zpl_set_acl and zpl_set_acl_impl, and add a new configure test for the new version. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes #12076 Closes #12093
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jun 2, 2021
Just like openzfs#12087, the set_acl signature changed with all the bolted-on *userns parameters, which disabled set_acl usage, and caused openzfs#12076. Turn zpl_set_acl into zpl_set_acl and zpl_set_acl_impl, and add a new configure test for the new version. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#12076 Closes openzfs#12093
tonyhutter
pushed a commit
that referenced
this pull request
Jun 23, 2021
Just like #12087, the set_acl signature changed with all the bolted-on *userns parameters, which disabled set_acl usage, and caused #12076. Turn zpl_set_acl into zpl_set_acl and zpl_set_acl_impl, and add a new configure test for the new version. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes #12076 Closes #12093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#12076
Description
Just like #12087, the set_acl signature changed with all the bolted-on
*userns parameters, which disabled set_acl usage, and caused #12076.
Wrap zpl_set_acl with zpl_set_acl2, and add a new configure test for
the new version.
How Has This Been Tested?
Without it, the test case from #12076 fails on 5.12.0 and works on 5.10.0 (on Debian sid) with the same codebase. With it, 5.12.0 and 5.10.0 both work.
Types of changes
Checklist:
Signed-off-by.