Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Linux kABI cosmetics #12103

Closed
wants to merge 2 commits into from
Closed

Various Linux kABI cosmetics #12103

wants to merge 2 commits into from

Conversation

nabijaczleweli
Copy link
Contributor

Motivation and Context

As seen in #12074 before

Description

Note the new 5.12 API, remove bogus bounds, don't try to use 3-argument vfs_getattr when unavailable.

How Has This Been Tested?

It, uh, builds, I think?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – CI take my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@behlendorf behlendorf self-assigned this May 24, 2021
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 24, 2021
behlendorf
behlendorf approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the cleanup!

@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing and removed Status: Code Review Needed Ready for review and testing labels May 24, 2021
@behlendorf behlendorf requested a review from tonyhutter May 24, 2021 23:40
@tonyhutter
Copy link
Contributor

Can you split this into two PRs? One with the functional changes:

 module/os/linux/zfs/zfs_file_os.c
 module/os/linux/spl/spl-generic.c

... and one with the documentation changes?

@nabijaczleweli
linux: don't fall through to 3-arg vfs_getattr
24ea70f 
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli
Various Linux kABI cosmetics
ff9bea1 
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@nabijaczleweli nabijaczleweli force-pushed the kernal-but-just-the-strong-bits branch from e73b3a7 to ff9bea1 Compare May 25, 2021 22:45
@nabijaczleweli
Copy link
Contributor Author

Wedged out those two into a separate commit.

tonyhutter
tonyhutter approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@tonyhutter tonyhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabijaczleweli thanks, looks good.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 26, 2021
behlendorf pushed a commit that referenced this pull request May 26, 2021
@nabijaczleweli @behlendorf
Various Linux kABI cosmetics
69cbd0a 
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12103
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 28, 2021
@nabijaczleweli @behlendorf
linux: don't fall through to 3-arg vfs_getattr
7cdd4dd 
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12103
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 28, 2021
@nabijaczleweli @behlendorf
Various Linux kABI cosmetics
6316086 
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12103
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@nabijaczleweli
linux: don't fall through to 3-arg vfs_getattr
27cd01a 
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12103
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@nabijaczleweli
Various Linux kABI cosmetics
60f167c 
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees

@behlendorf behlendorf

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabijaczleweli @tonyhutter @behlendorf