Quick fixes for two ZTS failures #12165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwk404
approved these changes
Jun 1, 2021
ghost
suggested changes
Jun 1, 2021
On FreeBSD 14, these two tests started erroring out like the objects they're attempting to examine don't exist. Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
|
One day, I will remember to search for macros before using raw commands. Today is evidently not that day. |
ghost
approved these changes
Jun 1, 2021
behlendorf
approved these changes
Jun 1, 2021
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jun 3, 2021
On FreeBSD 14, these two tests started erroring out like the objects they're attempting to examine don't exist. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#12165
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jun 8, 2021
On FreeBSD 14, these two tests started erroring out like the objects they're attempting to examine don't exist. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#12165
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jun 9, 2021
On FreeBSD 14, these two tests started erroring out like the objects they're attempting to examine don't exist. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: John Kennedy <john.kennedy@delphix.com> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Rich Ercolani <rincebrain@gmail.com> Closes openzfs#12165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
On FreeBSD 14, these two tests started erroring out every time.
Description
When you look at the bot log (in one case; the other test requires patching to not write stderr to /dev/null), the reason the tests are erroring is that zdb is spitting out
zdb: dmu_object_info() failed, errno 2(2 is ENOENT), which is what I expect to happen if you try to use zdb on an object too fast after it's created, I hypothesized because they're not flushed out yet.So I threw in a
zpool syncbefore the first zdb use in each test.Of course, that leaves the open question of what's changed? The same tests on the same git rev pass on 13-STABLE (examining all the failures of the last 20 on FreeBSD stable/13 amd64 (TEST), none of them report either of these tests)...
How Has This Been Tested?
The tests failed every time I tried before these changes and passed every time I've tried after.
Types of changes
Checklist:
Signed-off-by.