Detect iSCSI in the zpool cmd vdev media script #12206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Don Brady <don.brady@delphix.com>
tonyhutter
reviewed
Jun 10, 2021
| vpd_pg83="/sys/block/$device/device/vpd_pg83" | ||
| if [ -f "$vpd_pg83" ]; then | ||
| if grep -q --binary "iqn." "$vpd_pg83"; then | ||
| MEDIA="iscsi" |
There was a problem hiding this comment.
Since iscsi is the transport protocol, would it make sense to append iscsi to the disk type, like iscsi-hdd or iscsi-ssd? (I have not used iscsi so this may be a dumb question).
There was a problem hiding this comment.
I don't think the iSCSI protocol exposes the backend device type. But I'll try an experiment with both backends to see if we can see it. If so then a hybrid might make sense.
tonynguien
approved these changes
Jul 15, 2021
behlendorf
approved these changes
Jul 15, 2021
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 15, 2021
Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com> Signed-off-by: Don Brady <don.brady@delphix.com> Closes openzfs#12206
rincebrain
pushed a commit
to rincebrain/zfs
that referenced
this pull request
Sep 22, 2021
Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com> Signed-off-by: Don Brady <don.brady@delphix.com> Closes openzfs#12206
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In the
zpool statuscommand, the-c mediaoption shows whether a vdev is a file, hdd, or ssd. It would be nice to also support iSCSI devices as a media type.Description
Added support to the
mediascript to detect if a device is iSCSI.How Has This Been Tested?
manually tested with a pool comprised of iSCSI devices. Here are two example runs with the new detection:
Types of changes
Checklist:
Signed-off-by.