Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmu_zfetch_stream_fini leaks refcount #12294

Merged
merged 1 commit into from
Jul 1, 2021
Merged

dmu_zfetch_stream_fini leaks refcount #12294

merged 1 commit into from
Jul 1, 2021

Conversation

lundman
Copy link
Contributor

@lundman lundman commented Jun 29, 2021

dmu_zfetch_stream_fini() is missing calls to destroy the refcounts,
leaking them and the mutex inside.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

amotin
amotin reviewed Jun 29, 2021
View reviewed changes
module/zfs/dmu_zfetch.c Outdated Show resolved Hide resolved
@lundman lundman mentioned this pull request Jun 29, 2021
Open
13 tasks
@lundman
Upstream: dmu_zfetch_stream_fini leaks refcount
10268a4 
dmu_zfetch_stream_fini() is missing calls to destroy the refcounts,
leaking them and the mutex inside.

Signed-off-by: Jorgen Lundman <lundman@lundman.net>
@mmaybee mmaybee added the Status: Accepted Ready to integrate (reviewed, tested) label Jun 29, 2021
@mmaybee mmaybee merged commit eca1745 into openzfs:master Jul 1, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 23, 2021
@lundman @behlendorf
Upstream: dmu_zfetch_stream_fini leaks refcount
e9e60b7 
dmu_zfetch_stream_fini() is missing calls to destroy the refcounts,
leaking them and the mutex inside.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Jorgen Lundman <lundman@lundman.net>
Closes openzfs#12294
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@lundman @behlendorf
Upstream: dmu_zfetch_stream_fini leaks refcount
1b73f1a 
dmu_zfetch_stream_fini() is missing calls to destroy the refcounts,
leaking them and the mutex inside.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Jorgen Lundman <lundman@lundman.net>
Closes openzfs#12294
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@lundman
Upstream: dmu_zfetch_stream_fini leaks refcount
cfcf043 
dmu_zfetch_stream_fini() is missing calls to destroy the refcounts,
leaking them and the mutex inside.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Jorgen Lundman <lundman@lundman.net>
Closes openzfs#12294
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@lundman @behlendorf
Upstream: dmu_zfetch_stream_fini leaks refcount
cb1a5ad 
dmu_zfetch_stream_fini() is missing calls to destroy the refcounts,
leaking them and the mutex inside.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Jorgen Lundman <lundman@lundman.net>
Closes openzfs#12294
behlendorf pushed a commit that referenced this pull request Aug 31, 2021
@lundman @behlendorf
Upstream: dmu_zfetch_stream_fini leaks refcount
ccf3122 
dmu_zfetch_stream_fini() is missing calls to destroy the refcounts,
leaking them and the mutex inside.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Jorgen Lundman <lundman@lundman.net>
Closes #12294
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@lundman @tonyhutter
Upstream: dmu_zfetch_stream_fini leaks refcount
2334bc4 
dmu_zfetch_stream_fini() is missing calls to destroy the refcounts,
leaking them and the mutex inside.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Jorgen Lundman <lundman@lundman.net>
Closes openzfs#12294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@ahrens ahrens ahrens approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees

@mmaybee mmaybee

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lundman @behlendorf @ahrens @amotin @mmaybee