Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct zfs-send(8) on readonly sends #12336

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

rincebrain
Copy link
Contributor

Motivation and Context

zfs-send(8) claimed you could use -pR when sending a readonly filesystem
or volume. You cannot.

The usage output for zfs send already reflects this.

Description

As above.

I suspect this never worked, but admit I have not tried firing up an old version or going source spelunking to verify this - I just got burned by this when helping someone send|recv from a readonly import during recovery, and wanted to at a minimum ensure nobody else is misled by the man page.

(I also noticed testing for other discrepancies between the man page and usage output for the r/o case that the usage didn't list -D even though it "works" fine. I know it's a noop, and going away Real Soon Now(tm), but it seemed better to list it (and eventually have it removed with the other instances) than either leaving the discrepancy or deleting it from the man page.)

How Has This Been Tested?

Well, I ran mancheck, and looked at the man output.

If I broke something with the zfs_main.c edit, I will be quite impressed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

zfs-send(8) claimed in the flags list you could use -pR when sending
a readonly filesystem or volume. You cannot.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 8, 2021
@tonynguien tonynguien added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 15, 2021
@tonynguien tonynguien merged commit b7ec530 into openzfs:master Jul 16, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 23, 2021
zfs-send(8) claimed in the flags list you could use -pR when sending
a readonly filesystem or volume. You cannot.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12336
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
zfs-send(8) claimed in the flags list you could use -pR when sending
a readonly filesystem or volume. You cannot.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12336
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
zfs-send(8) claimed in the flags list you could use -pR when sending
a readonly filesystem or volume. You cannot.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12336
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
zfs-send(8) claimed in the flags list you could use -pR when sending
a readonly filesystem or volume. You cannot.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12336
behlendorf pushed a commit that referenced this pull request Aug 31, 2021
zfs-send(8) claimed in the flags list you could use -pR when sending
a readonly filesystem or volume. You cannot.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes #12336
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
zfs-send(8) claimed in the flags list you could use -pR when sending
a readonly filesystem or volume. You cannot.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Nguyen <tony.nguyen@delphix.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants