Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify checksum obtain method of QAT #12343

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Modify checksum obtain method of QAT #12343

merged 1 commit into from
Aug 3, 2021

Conversation

hedongzhang
Copy link
Contributor

CpaDcGeneratefooter function that obtain the checksum code does not support the CPA_DC_STATELESS mode. So we get the adler32 chencksum of the end of the zlib from dc_results

Fix QAT compress defects: Zlib may not be able to decompress some data compressed using QAT #12317

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jul 13, 2021
@behlendorf
Copy link
Contributor

@wli5 @cfzhu would you mind taking a look at this proposed QAT fix.

@cfzhu
Copy link
Contributor

cfzhu commented Jul 14, 2021

Thanks Hedong, @hedongzhang ,for your pull request, I need to reproduce this issue, could you provide more information?

@hedongzhang
Copy link
Contributor Author

Hi @cfzhu ，As communicated before, this PR has nothing to do with that issue #12317, only optimizes the checksum acquisition. Do you think this is necessary？

@tonynguien
Copy link
Contributor

@hedongzhang Can you address these minor cstyle issues? Thanks.
Run make checkstyle ./module/os/linux/zfs/qat_compress.c: 423: line > 80 characters Error: line > 80 characters ./module/os/linux/zfs/qat_compress.c: 424: space or tab at end of line Error: space or tab at end of line make: *** [cstyle] Error 1 Makefile:1505: recipe for target 'cstyle' failed Error: Process completed with exit code 2.

@cfzhu
Copy link
Contributor

cfzhu commented Jul 20, 2021

Hi Hedong @hedongzhang, sorry for my late replay, I need to do some tests for this, and all tests passed, I approved your request, thanks for your help.

@hedongzhang
Copy link
Contributor Author

@cfzhu @tonynguien OK，I've had it repaired

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jul 26, 2021
@behlendorf
Copy link
Contributor

@hedongzhang can you 1) squash these commits and rebase this against the latest master branch, 2) add your signed-off-by to the commit message, and 3) force update the PR. Then this should be ready to go.

git commit --amend -s

@hedongzhang hedongzhang force-pushed the master branch 2 times, most recently from 9d9f2b0 to 99aa0e3 Compare July 28, 2021 13:06
@hedongzhang
Copy link
Contributor Author

Hi @behlendorf , I closed this PR accidentally，can you reopen it?

@behlendorf behlendorf reopened this Jul 28, 2021
@behlendorf
Copy link
Contributor

No problem, reopened.

Modify checksum obtain method of QAT
02bc719 
CpaDcGeneratefooter function that obtain the checksum code
does not support the CPA_DC_STATELESS mode. So we get the
adler32 chencksum of the end of the zlib from dc_results.

Signed-off-by: hedong.zhang <h_d_zhang@163.com>
@tonynguien tonynguien merged commit 4357552 into openzfs:master Aug 3, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 23, 2021
@behlendorf
Modify checksum obtain method of QAT
e90a3e5 
CpaDcGeneratefooter function that obtain the checksum code
does not support the CPA_DC_STATELESS mode. So we get the
adler32 chencksum of the end of the zlib from dc_results.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Chengfei Zhu <chengfeix.zhu@intel.com>
Signed-off-by: hedong.zhang <h_d_zhang@163.com>
Closes openzfs#12343
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@behlendorf
Modify checksum obtain method of QAT
b94b3f3 
CpaDcGeneratefooter function that obtain the checksum code
does not support the CPA_DC_STATELESS mode. So we get the
adler32 chencksum of the end of the zlib from dc_results.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Chengfei Zhu <chengfeix.zhu@intel.com>
Signed-off-by: hedong.zhang <h_d_zhang@163.com>
Closes openzfs#12343
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
Modify checksum obtain method of QAT
586b9d3 
CpaDcGeneratefooter function that obtain the checksum code
does not support the CPA_DC_STATELESS mode. So we get the
adler32 chencksum of the end of the zlib from dc_results.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Chengfei Zhu <chengfeix.zhu@intel.com>
Signed-off-by: hedong.zhang <h_d_zhang@163.com>
Closes openzfs#12343
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@behlendorf
Modify checksum obtain method of QAT
bae37f1 
CpaDcGeneratefooter function that obtain the checksum code
does not support the CPA_DC_STATELESS mode. So we get the
adler32 chencksum of the end of the zlib from dc_results.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Chengfei Zhu <chengfeix.zhu@intel.com>
Signed-off-by: hedong.zhang <h_d_zhang@163.com>
Closes openzfs#12343
behlendorf pushed a commit that referenced this pull request Aug 31, 2021
@behlendorf
Modify checksum obtain method of QAT
44c1eed 
CpaDcGeneratefooter function that obtain the checksum code
does not support the CPA_DC_STATELESS mode. So we get the
adler32 chencksum of the end of the zlib from dc_results.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Chengfei Zhu <chengfeix.zhu@intel.com>
Signed-off-by: hedong.zhang <h_d_zhang@163.com>
Closes #12343
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@tonyhutter
Modify checksum obtain method of QAT
ddb732e 
CpaDcGeneratefooter function that obtain the checksum code
does not support the CPA_DC_STATELESS mode. So we get the
adler32 chencksum of the end of the zlib from dc_results.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Chengfei Zhu <chengfeix.zhu@intel.com>
Signed-off-by: hedong.zhang <h_d_zhang@163.com>
Closes openzfs#12343
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
@rincebrain
Modify checksum obtain method of QAT
f793098 
CpaDcGeneratefooter function that obtain the checksum code
does not support the CPA_DC_STATELESS mode. So we get the
adler32 chencksum of the end of the zlib from dc_results.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Chengfei Zhu <chengfeix.zhu@intel.com>
Signed-off-by: hedong.zhang <h_d_zhang@163.com>
Closes openzfs#12343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzhu cfzhu cfzhu approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees

@tonynguien tonynguien

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hedongzhang @behlendorf @cfzhu @tonynguien