Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When raw sending in chunks, use the physical payload size #12424

Closed
wants to merge 1 commit into from

Conversation

gamanakis
Copy link
Contributor

Motivation and Context

Closes #12275.

Description

When raw sending and splitting data in chunks dmu_dump_write() will
panic as it tries to dereference a NULL block pointer. In the same case
use the physical payload size instead of the logical one to determine
the number of chunks needed.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

When raw sending and splitting data in chunks dmu_dump_write() will
panic as it tries to dereference a NULL block pointer. In the same case
use the physical payload size instead of the logical one to determine
the number of chunks needed.

Signed-off-by: George Amanakis <gamanakis@gmail.com>
@gamanakis
Copy link
Contributor Author

@pcd1193182 would you mind taking a look? Thanks.

@gamanakis
Copy link
Contributor Author

After more careful consideration of the current codebase it seems it's not possible to raw send in small chunks. Closing this.

@gamanakis gamanakis closed this Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux 'kernel NULL pointer dereference' on zfs send of a specific encrypted snapshot
1 participant