zpool-remove.8: describe top-level vdev sector size limitation #12472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmelikov
approved these changes
Aug 12, 2021
smammy
force-pushed
the
zpool-remove-document-sector-size-limitation
branch
from
b2af61d to
55560c1
Compare
|
Sorry if I messed things up by force-pushing a commit here. (I had a commit message line longer than 72 chars, so checkstyle was failing.) |
behlendorf
reviewed
Aug 13, 2021
| .Pp | ||
| Top-level vdevs can only be removed if the primary pool storage does not contain | ||
| a top-level raidz vdev, all top-level vdevs have the same sector size, and the | ||
| keys for all encrypted datasets are loaded. |
There was a problem hiding this comment.
Thanks for mentioning the sector size restriction, however I think in the updated wording we should make it clear these restriction don't apply to spares, cache and log devices. Only top-level vdevs which are part of the primary pool storage (singletons, mirrors, dedup, and special vdevs). The pool also cannot contain either raidz or draid vdevs.
There was a problem hiding this comment.
Good point. I'll re-work it to be clearer.
There was a problem hiding this comment.
@behlendorf I pushed 9f93ea4 with what I think is clearer wording.
Document that top-level vdevs cannot be removed unless all top-level vdevs have the same sector size. Signed-off-by: Sam Hathaway <sam@sam-hathaway.com> Closes: #11339
smammy
force-pushed
the
zpool-remove-document-sector-size-limitation
branch
from
55560c1 to
9f93ea4
Compare
behlendorf
added
Status: Code Review Needed
behlendorf
approved these changes
Aug 23, 2021
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Aug 23, 2021
Document that top-level vdevs cannot be removed unless all top-level vdevs have the same sector size. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Sam Hathaway <sam@sam-hathaway.com> Closes openzfs#11339 Closes openzfs#12472
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Aug 24, 2021
Document that top-level vdevs cannot be removed unless all top-level vdevs have the same sector size. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Sam Hathaway <sam@sam-hathaway.com> Closes openzfs#11339 Closes openzfs#12472
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Aug 24, 2021
Document that top-level vdevs cannot be removed unless all top-level vdevs have the same sector size. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Sam Hathaway <sam@sam-hathaway.com> Closes openzfs#11339 Closes openzfs#12472
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Aug 24, 2021
Document that top-level vdevs cannot be removed unless all top-level vdevs have the same sector size. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Sam Hathaway <sam@sam-hathaway.com> Closes openzfs#11339 Closes openzfs#12472
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Sep 15, 2021
Document that top-level vdevs cannot be removed unless all top-level vdevs have the same sector size. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Sam Hathaway <sam@sam-hathaway.com> Closes openzfs#11339 Closes openzfs#12472
rincebrain
pushed a commit
to rincebrain/zfs
that referenced
this pull request
Sep 22, 2021
Document that top-level vdevs cannot be removed unless all top-level vdevs have the same sector size. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Sam Hathaway <sam@sam-hathaway.com> Closes openzfs#11339 Closes openzfs#12472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that top-level vdevs cannot be removed unless all top-level vdevs have the same sector size.
Signed-off-by: Sam Hathaway sam@sam-hathaway.com
Closes: #11339
Motivation and Context
It is currently undocumented that top-level vdevs cannot be removed unless all top-level vdevs have the same sector size. This patch adds this fact to zpool-remove.8.
Description
This patch adds text to zpool-remove.8 to explain that top-level vdevs cannot be removed unless all top-level vdevs have the same sector size.
How Has This Been Tested?
I compiled the manpage to ensure that I hadn't broken anything.
Types of changes
Checklist:
Signed-off-by.