Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject zfs send -RI with nonexistent fromsnap #12575

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Reject zfs send -RI with nonexistent fromsnap #12575

merged 1 commit into from
Oct 4, 2021

Conversation

rincebrain
Copy link
Contributor

Motivation and Context

#12574

Description

Just bolt a check for fromsnap validity into libzfs_sendrecv, flagrantly stolen from the tosnap check immediately below.

How Has This Been Tested?

A run of zfs-tests.sh -r sanity, plus the obvious

# cmd/zfs/zfs send -R -I mypool@nonsense mypool@snap5 | cat > /dev/null
cannot open 'mypool@nonsense': dataset does not exist
# zfs send -R -I mypool@nonsense mypool@snap5 | cat > /dev/null
#

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@rincebrain
Reject zfs send -RI with nonexistent fromsnap
6dfad72 
Right now, zfs send -I dataset@nonexistent dataset@existent fails, but
zfs send -RI dataset@nonexistent dataset@existent does not.

Closes: openzfs#12574

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 20, 2021
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 1, 2021
@behlendorf behlendorf merged commit aad91df into openzfs:master Oct 4, 2021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jun 7, 2022
@rincebrain @tonyhutter
Reject zfs send -RI with nonexistent fromsnap
2712411 
Right now, zfs send -I dataset@nonexistent dataset@existent fails, but
zfs send -RI dataset@nonexistent dataset@existent does not.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12574
Closes openzfs#12575
ghost pushed a commit to truenas/zfs that referenced this pull request Jun 27, 2022
@rincebrain
Reject zfs send -RI with nonexistent fromsnap
1527b7e 
Right now, zfs send -I dataset@nonexistent dataset@existent fails, but
zfs send -RI dataset@nonexistent dataset@existent does not.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12574
Closes openzfs#12575
ghost pushed a commit to truenas/zfs that referenced this pull request Jun 29, 2022
@rincebrain
Reject zfs send -RI with nonexistent fromsnap
4a540d6 
Right now, zfs send -I dataset@nonexistent dataset@existent fails, but
zfs send -RI dataset@nonexistent dataset@existent does not.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#12574
Closes openzfs#12575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rincebrain @behlendorf