Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.1] Detect HAVE_LARGE_STACKS at compile time #12584

Merged
merged 1 commit into from
Nov 1, 2021
Merged

[2.1] Detect HAVE_LARGE_STACKS at compile time #12584

merged 1 commit into from
Nov 1, 2021

Conversation

kev009
Copy link
Contributor

@kev009 kev009 commented Sep 23, 2021

Move HAVE_LARGE_STACKS definitions to header and set when appropriate.

Reviewed-by: Brian Behlendorf behlendorf1@llnl.gov
Reviewed-by: Allan Jude allan@klarasystems.com
Reviewed-by: Alexander Motin mav@FreeBSD.org
Reviewed-by: Ryan Moeller ryan@iXsystems.com
Signed-off-by: Kevin Bowling kbowling@FreeBSD.org
Closes #12350

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@kev009
Detect HAVE_LARGE_STACKS at compile time
7b9cc28 
Move HAVE_LARGE_STACKS definitions to header and set when appropriate.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Kevin Bowling <kbowling@FreeBSD.org>
Closes openzfs#12350
@kev009 kev009 changed the title Detect HAVE_LARGE_STACKS at compile time [2.1] Detect HAVE_LARGE_STACKS at compile time Sep 23, 2021
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 23, 2021
ghost
ghost approved these changes Sep 23, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good.

@tonyhutter tonyhutter merged commit d8a97a7 into openzfs:zfs-2.1.2-staging Nov 1, 2021
ghost pushed a commit to truenas/zfs that referenced this pull request Nov 3, 2021
@kev009
Detect HAVE_LARGE_STACKS at compile time (openzfs#12584)
6228204 
Move HAVE_LARGE_STACKS definitions to header and set when appropriate.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Allan Jude <allan@klarasystems.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Kevin Bowling <kbowling@FreeBSD.org>
Closes openzfs#12350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees

@jwk404 jwk404

Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kev009 @tonyhutter @behlendorf @jwk404