Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spa.c: Replace VERIFY(nvlist_*(...) == 0) with fnvlist_* #12678

Merged
merged 1 commit into from
Oct 26, 2021
Merged

spa.c: Replace VERIFY(nvlist_*(...) == 0) with fnvlist_* #12678

merged 1 commit into from
Oct 26, 2021

Conversation

allanjude
Copy link
Contributor

Motivation and Context

This cleanup was suggested by Matt Ahrens during review on vdev properties

Description

Replace all VERIFY(nvlist_*(...) == 0) with fnvlist_* in spa.c

The fnvlist versions of the functions are fatal if they fail,
saving each call from having to include checking the result.

How Has This Been Tested?

It compiles

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@allanjude
spa.c: Replace VERIFY(nvlist_*(...) == 0) with fnvlist_*
b5a85b2 
The fnvlist versions of the functions are fatal if they fail,
saving each call from having to include checking the result.

Signed-off-by: Allan Jude <allan@klarasystems.com>
@allanjude allanjude mentioned this pull request Oct 23, 2021
Merged
13 tasks
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 25, 2021
@mmaybee mmaybee merged commit 65ad5d1 into openzfs:master Oct 26, 2021
amotin pushed a commit to truenas/zfs that referenced this pull request Feb 22, 2022
@allanjude @amotin
spa.c: Replace VERIFY(nvlist_*(...) == 0) with fnvlist_* (openzfs#12678)
772d64e 
The fnvlist versions of the functions are fatal if they fail,
saving each call from having to include checking the result.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Signed-off-by: Allan Jude <allan@klarasystems.com>
(cherry picked from commit 65ad5d1)
amotin pushed a commit to amotin/zfs that referenced this pull request Jul 20, 2022
@allanjude @amotin
spa.c: Replace VERIFY(nvlist_*(...) == 0) with fnvlist_* (openzfs#12678)
b36dae6 
The fnvlist versions of the functions are fatal if they fail,
saving each call from having to include checking the result.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Signed-off-by: Allan Jude <allan@klarasystems.com>
behlendorf pushed a commit that referenced this pull request Jul 26, 2022
@allanjude @behlendorf
spa.c: Replace VERIFY(nvlist_*(...) == 0) with fnvlist_* (#12678)
72a4709 
The fnvlist versions of the functions are fatal if they fail,
saving each call from having to include checking the result.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikozhukhov ikozhukhov ikozhukhov approved these changes

@ahrens ahrens ahrens approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees

@mmaybee mmaybee

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@allanjude @behlendorf @ahrens @ikozhukhov @mmaybee