Set DEFAULT_INIT_SHELL to /sbin/openrc-run for Gentoo and Alpine #12692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gentoo and Alpine always set the rc init scripts' shebang to #!/sbin/openrc-run, whether or not openrc is installed. Signed-off-by: Peter Levine <plevine457@gmail.com>
behlendorf
approved these changes
Oct 27, 2021
xin3liang
pushed a commit
to xin3liang/zfs
that referenced
this pull request
Feb 28, 2023
Gentoo and Alpine always set the rc init scripts' shebang to #!/sbin/openrc-run, whether or not openrc is installed. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Peter Levine <plevine457@gmail.com> Closes openzfs#12683 Closes openzfs#12692
xin3liang
pushed a commit
to xin3liang/zfs
that referenced
this pull request
Feb 28, 2023
Add config support for openEuler, so that it set the right sysconfig dir for openEuler. And DEFAULT_INIT_SCRIPT is no longer needed since commit "2a34db1bd Base init scripts for SYSV systems". Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org> Closes openzfs#14241 Set DEFAULT_INIT_SHELL to /sbin/openrc-run for Gentoo and Alpine Gentoo and Alpine always set the rc init scripts' shebang to Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Peter Levine <plevine457@gmail.com> Closes openzfs#12683 Closes openzfs#12692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gentoo and Alpine always set the rc init scripts' shebang to
#!/sbin/openrc-run, whether or not openrc is installed.Motivation and Context
Fixes #12683
Description
Unconditionally sets
DEFAULT_INIT_SHELL="/sbin/openrc-run"for Gentoo and Alpine to ensure the correct shebang is always used regardless of build-time availability of openrc-run.How Has This Been Tested?
mv /sbin/openrc-run /sbin/openrc-run.oldebuild /var/db/repos/gentoo/sys-fs/zfs/zfs-2.1.1-r2.ebuild unpack.Edited /var/tmp/portage/sys-fs/zfs-2.1.1-r2/work/zfs-2.1.1/config/zfs-build.m4 to reflect changes in this PR.
ebuild /var/db/repos/gentoo/sys-fs/zfs/zfs-2.1.1-r2.ebuild merge.Confirmed correct shebang.
mv /sbin/openrc-run.old /sbin/openrc-runTypes of changes
Checklist:
Signed-off-by.