Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude zfs_copies_003_pos on Linux #12738

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Exclude zfs_copies_003_pos on Linux #12738

merged 1 commit into from
Nov 10, 2021

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Suppress understood common CI failures, #12301.

Description

This test case may fail on 5.13 and newer Linux kernels if the
/dev/zvol/ device is not created by udev.

How Has This Been Tested?

It has not.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Nov 9, 2021
@behlendorf behlendorf requested review from jwk404 and gmelikov November 9, 2021 20:42
@behlendorf
Copy link
Contributor Author

cc: @rincebrain

@jwk404 jwk404 added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 9, 2021
@tonyhutter
Copy link
Contributor

tonyhutter commented Nov 9, 2021 •
edited
Loading

The checkstyle failure is a known issue (#12739) that's unrelated to this PR

@jwk404
Copy link
Contributor

jwk404 commented Nov 10, 2021

Would you mind rebasing and pushing with #12722 to get a passing checkstyle?

@behlendorf
Exclude zfs_copies_003_pos on Linux
831c3d3 
This test case may fail on 5.13 and newer Linux kernels if the
/dev/zvol/ device is not created by udev.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#12301
@behlendorf
Copy link
Contributor Author

Done. I think this should be good to go once the style checks come back clean.

@jwk404 jwk404 merged commit 371e0f7 into openzfs:master Nov 10, 2021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
@behlendorf @tonyhutter
Exclude zfs_copies_003_pos on Linux
ea0dda5 
This test case may fail on 5.13 and newer Linux kernels if the
/dev/zvol/ device is not created by udev.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#12301
Closes  openzfs#12738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@jwk404 jwk404 jwk404 approved these changes

@rincebrain rincebrain rincebrain approved these changes

Assignees

@jwk404 jwk404

Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@behlendorf @tonyhutter @jwk404 @rincebrain @gmelikov