Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init.d/zfs-mount: Don't fsck or mount/umount fstab entries #12780

Merged
merged 1 commit into from
Apr 15, 2022
Merged

init.d/zfs-mount: Don't fsck or mount/umount fstab entries #12780

merged 1 commit into from
Apr 15, 2022

Conversation

omnivagant
Copy link
Contributor

@omnivagant omnivagant commented Nov 21, 2021 •
edited
Loading

This is better handled by existing OS toolset.

Motivation and Context

#7374

Description

Code removal.

How Has This Been Tested?

By rebooting an Alpinelinux 3.15.0_rc4 installation with zvols as well as datasets with mountpoint=legacy in fstab.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@omnivagant
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
1cb1521 
This is better handled by existing OS toolset.

Signed-off-by: omni <omni+vagant@hack.org>
@omnivagant
Copy link
Contributor Author

omnivagant commented Nov 22, 2021 •
edited
Loading

This may be too drastic, I haven't thought of mountpoint=legacy yet. Nah, is ok.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 17, 2021
algitbot pushed a commit to alpinelinux/aports that referenced this pull request Apr 14, 2022
@ncopa
main/zfs: upgrade to 2.1.4
48cca9d 
Update upstream URL, source and pkgdesc.  By 2.0.0 ZoL became OpenZFS
and is a common effort with FreeBSD developers.

Enable on armhf and armv7.

Let OS handle fsck, mount & umount of fstab entries.  I've been running
with this patch since November last year.  Context:

  openzfs/zfs#12780
  openzfs/zfs#7374
szubersk
szubersk approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@szubersk szubersk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was tested enough by the author and already accepted by the downstream alpinelinux/aports@48cca9d

The log message needs shortening to <50 characters though.

@behlendorf
Copy link
Contributor

Agreed, let's move forward with this bit of removal. Thanks for taking another look.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 15, 2022
@behlendorf behlendorf merged commit ec4d860 into openzfs:master Apr 15, 2022
@nabijaczleweli nabijaczleweli mentioned this pull request Apr 16, 2022
Closed
13 tasks
@pcd1193182 pcd1193182 mentioned this pull request Apr 19, 2022
Merged
13 tasks
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@omnivagant @nicman23
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
db1779a 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@omnivagant @nicman23
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
353a139 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 2, 2022
@omnivagant @lundman
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
c4cdcdb 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@omnivagant @beren12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
7166d3b 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
c967e24 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
7a20497 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
70b4921 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
064c81a 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
c4a4756 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
859ae81 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
0c6e15a 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
15c91cd 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
89c6c8a 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
46219d2 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
03d5ae2 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
a275edd 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
e2ac9af 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
8b94bc3 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
f2e9819 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
415c3c1 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
7fde13e 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@omnivagant @andrewc12
init.d/zfs-mount: Don't fsck or mount/umount fstab entries
d52e467 
This is better handled by existing OS toolset.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: omni <omni+vagant@hack.org>
Issue openzfs#7374
Closes openzfs#12780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szubersk szubersk szubersk approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees

@tonynguien tonynguien

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omnivagant @behlendorf @szubersk @tonynguien