Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

man: speling #12911

Merged
merged 1 commit into from
Jan 6, 2022
Merged

man: speling #12911

merged 1 commit into from
Jan 6, 2022

Conversation

chrisrd
Copy link
Contributor

@chrisrd chrisrd commented Dec 24, 2021

Motivation and Context

Spelling fixes

How Has This Been Tested?

Aspell with a localised dictionary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

rincebrain
rincebrain reviewed Dec 24, 2021
View reviewed changes
man/man8/zpool-events.8 Outdated
@@ -136,7 +136,7 @@ Issued when the ashift alignment requirement has increased.
.It Sy vdev.remove
Issued when a vdev is detached from a mirror (or a spare detached from a
vdev where it have been used to replace a failed drive - only works if
the original drive have been readded).
the original drive have been read).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, readded (or re-added) was correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Updated to "re-added". Tks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] PR title: it's "spelling", not "speling"
:)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Speling" is an long standing trope or joke - goes back to at least 1908: https://publicdomainreview.org/collection/the-pioneer-ov-simplified-speling-vol-1-no-1-1912 ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, apologies, a non-native here.

@chrisrd
man: speling
cc9c54a 
Fix spelling.

Signed-off-by: Chris Dunlop <chris@onthe.net.au>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jan 5, 2022
@behlendorf behlendorf merged commit 0175272 into openzfs:master Jan 6, 2022
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 7, 2022
@chrisrd @mcmilk
man: speling
68c538f 
Fix spelling.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Closes openzfs#12911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 10, 2022
@chrisrd @tonyhutter
man: speling
037c233 
Fix spelling.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Closes openzfs#12911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 14, 2022
@chrisrd @tonyhutter
man: speling
01c389c 
Fix spelling.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Closes openzfs#12911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 16, 2022
@chrisrd @tonyhutter
man: speling
46b92af 
Fix spelling.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Closes openzfs#12911
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 17, 2022
@chrisrd @tonyhutter
man: speling
5987838 
Fix spelling.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Closes openzfs#12911
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@chrisrd @nicman23
man: speling
569974e 
Fix spelling.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Closes openzfs#12911
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@chrisrd @nicman23
man: speling
bc9a019 
Fix spelling.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Closes openzfs#12911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rincebrain rincebrain rincebrain left review comments

@szubersk szubersk szubersk left review comments

@behlendorf behlendorf behlendorf approved these changes

@ahrens ahrens ahrens approved these changes

Assignees

@tonynguien tonynguien

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrisrd @behlendorf @rincebrain @ahrens @szubersk @tonynguien