Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: libzfs: mount: fix uninitialised flags #12954

Merged
merged 1 commit into from
Jan 13, 2022
Merged

linux: libzfs: mount: fix uninitialised flags #12954

merged 1 commit into from
Jan 13, 2022
+1 −1

Conversation

nabijaczleweli
Copy link
Contributor

Description

See commit message.

How Has This Been Tested?

Fixes valgrind warning.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – CI take my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli
linux: libzfs: mount: fix uninitialised flags
fcda68c 
They're later |=d with constants, but never reset

Caught by valgrind while investigating
openzfs#12928 (comment)

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 11, 2022
@behlendorf behlendorf merged commit 4737a9e into openzfs:master Jan 13, 2022
ghost pushed a commit to truenas/zfs that referenced this pull request Jan 19, 2022
@nabijaczleweli
linux: libzfs: mount: fix uninitialised flags
eb6228a 
They're later |=d with constants, but never reset

Caught by valgrind while investigating
openzfs#12928 (comment)

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12954
ghost pushed a commit to truenas/zfs that referenced this pull request Feb 2, 2022
@nabijaczleweli
linux: libzfs: mount: fix uninitialised flags
dd85076 
They're later |=d with constants, but never reset

Caught by valgrind while investigating
openzfs#12928 (comment)

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12954
tonyhutter pushed a commit that referenced this pull request Feb 3, 2022
@nabijaczleweli @tonyhutter
linux: libzfs: mount: fix uninitialised flags
c9c9d63 
They're later |=d with constants, but never reset

Caught by valgrind while investigating
#12928 (comment)

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12954
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
linux: libzfs: mount: fix uninitialised flags
ac86e54 
They're later |=d with constants, but never reset

Caught by valgrind while investigating
openzfs#12928 (comment)

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12954
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
linux: libzfs: mount: fix uninitialised flags
57c70b7 
They're later |=d with constants, but never reset

Caught by valgrind while investigating
openzfs#12928 (comment)

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12954
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Oct 22, 2022
@nabijaczleweli @snajpa
linux: libzfs: mount: fix uninitialised flags
2df97d9 
They're later |=d with constants, but never reset

Caught by valgrind while investigating
openzfs#12928 (comment)

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12954
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Oct 22, 2022
@nabijaczleweli @snajpa
linux: libzfs: mount: fix uninitialised flags
404b545 
They're later |=d with constants, but never reset

Caught by valgrind while investigating
openzfs#12928 (comment)

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12954
snajpa pushed a commit to vpsfreecz/zfs that referenced this pull request Oct 23, 2022
@nabijaczleweli @snajpa
linux: libzfs: mount: fix uninitialised flags
53c09c4 
They're later |=d with constants, but never reset

Caught by valgrind while investigating
openzfs#12928 (comment)

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes openzfs#12954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabijaczleweli @behlendorf