Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkabi/storeabi relevant only to x86_64 #13104

Merged
merged 1 commit into from
Feb 16, 2022
Merged

checkabi/storeabi relevant only to x86_64 #13104

merged 1 commit into from
Feb 16, 2022

Conversation

szubersk
Copy link
Contributor

@szubersk szubersk commented Feb 14, 2022 •
edited
Loading

Motivation and Context

Close #11345.

Description

Avoid checking ABI on x86_64 architectures.

How Has This Been Tested?

no testing was done

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Feb 14, 2022
@behlendorf behlendorf requested a review from gmelikov February 14, 2022 20:08
gmelikov
gmelikov reviewed Feb 14, 2022
View reviewed changes
config/Abigail.am Outdated Show resolved Hide resolved
@szubersk szubersk changed the title checkabi target relevant only to 64-bit archs checkabi/storeabi relevant only to x86_64 Feb 15, 2022
@szubersk szubersk requested a review from gmelikov February 15, 2022 18:41
gmelikov
gmelikov reviewed Feb 15, 2022
View reviewed changes
config/Abigail.am Outdated Show resolved Hide resolved
@szubersk szubersk requested a review from gmelikov February 15, 2022 21:16
@szubersk
checkabi/storeabi relevant only to x86_64
8ea8ab0 
Close #11345.

Signed-off-by: szubersk <szuberskidamian@gmail.com>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 16, 2022
@behlendorf behlendorf merged commit ba60051 into openzfs:master Feb 16, 2022
@szubersk szubersk deleted the szubersk-checkabi branch February 18, 2022 20:20
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@szubersk @nicman23
checkabi/storeabi relevant only to x86_64
8d7f6ff 
The stored ABI files are for the x86_64 architecture.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#11345
Closes openzfs#13104
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@szubersk @nicman23
checkabi/storeabi relevant only to x86_64
615decc 
The stored ABI files are for the x86_64 architecture.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#11345
Closes openzfs#13104
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Aug 30, 2022
@szubersk @andrewc12
checkabi/storeabi relevant only to x86_64
6503887 
The stored ABI files are for the x86_64 architecture.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#11345
Closes openzfs#13104
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 1, 2022
@szubersk @lundman
checkabi/storeabi relevant only to x86_64
a1f5595 
The stored ABI files are for the x86_64 architecture.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#11345
Closes openzfs#13104
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@szubersk @andrewc12
checkabi/storeabi relevant only to x86_64
ed6d493 
The stored ABI files are for the x86_64 architecture.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#11345
Closes openzfs#13104
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@szubersk @andrewc12
checkabi/storeabi relevant only to x86_64
1130d08 
The stored ABI files are for the x86_64 architecture.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#11345
Closes openzfs#13104
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@szubersk @andrewc12
checkabi/storeabi relevant only to x86_64
3c521bf 
The stored ABI files are for the x86_64 architecture.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes openzfs#11345
Closes openzfs#13104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checkabi fails on 32-bit architecture
3 participants
@szubersk @behlendorf @gmelikov