Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix erroneous zstreamdump warning #13154

Merged
merged 1 commit into from
Feb 26, 2022
Merged

Fix erroneous zstreamdump warning #13154

merged 1 commit into from
Feb 26, 2022

Conversation

pcd1193182
Copy link
Contributor

Motivation and Context

When using zstream dump on a normal send stream that contains objects with bonus buffers, you get something like the following warning: Warning: Object 34 has bonuslen = 176 > raw_bonuslen = 0. This is because we always compare the bonuslen to the raw_bonuslen, but we only set the raw_bonuslen for raw sends.

Description

We check the featureflags to see if this is a raw send before doing the bonuslen check.

How Has This Been Tested?

Tested on a send stream created without raw send, verified that no warning was erroneously printed. Passes zfs test suite.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added Component: Send/Recv "zfs send/recv" feature Status: Code Review Needed Ready for review and testing labels Feb 25, 2022
@behlendorf
Copy link
Contributor

Style warnings aside this looks good to me.

cc: @gamanakis

@gamanakis
Copy link
Contributor

Thanks for catching this! Looks good to me.

@pcd1193182
Fix erroneous zstreamdump warning
77ef227 
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 26, 2022
@behlendorf behlendorf merged commit 82226e4 into openzfs:master Feb 26, 2022
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Mar 1, 2022
@pcd1193182 @tonyhutter
Fix erroneous zstreamdump warning
eafb500 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Mar 1, 2022
@pcd1193182 @tonyhutter
Fix erroneous zstreamdump warning
ddcdccb 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@pcd1193182 @nicman23
Fix erroneous zstreamdump warning
ef5482e 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@pcd1193182 @nicman23
Fix erroneous zstreamdump warning
2c0fe86 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Aug 30, 2022
@pcd1193182 @andrewc12
Fix erroneous zstreamdump warning
4a47afc 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 1, 2022
@pcd1193182 @lundman
Fix erroneous zstreamdump warning
8602b80 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@pcd1193182 @andrewc12
Fix erroneous zstreamdump warning
810cfc3 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@pcd1193182 @andrewc12
Fix erroneous zstreamdump warning
f296480 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@pcd1193182 @andrewc12
Fix erroneous zstreamdump warning
99a3346 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@pcd1193182 @andrewc12
Fix erroneous zstreamdump warning
6044a8f 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@pcd1193182 @andrewc12
Fix erroneous zstreamdump warning
70b6665 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@pcd1193182 @andrewc12
Fix erroneous zstreamdump warning
28f78e1 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#13154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Component: Send/Recv "zfs send/recv" feature Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcd1193182 @behlendorf @gamanakis