Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD: add missing replay check to an assert in zfs_xvattr_set #13219

Merged
merged 1 commit into from
Mar 17, 2022
Merged

FreeBSD: add missing replay check to an assert in zfs_xvattr_set #13219

merged 1 commit into from
Mar 17, 2022

Conversation

mjguzik
Copy link
Contributor

@mjguzik mjguzik commented Mar 15, 2022 •
edited
Loading

Signed-off-by: Mateusz Guzik mjguzik@gmail.com

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mjguzik
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
ee38efb 
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
ghost
ghost approved these changes Mar 15, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I checked to make sure, everywhere else using ASSERT_VOP_IN_SEQC checks for replay in this way.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 15, 2022
@behlendorf behlendorf merged commit a5920d2 into openzfs:master Mar 17, 2022
usaleem-ix pushed a commit to truenas/zfs that referenced this pull request Mar 18, 2022
@mjguzik @usaleem-ix
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
b7cbb2f 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
@usaleem-ix usaleem-ix mentioned this pull request Mar 18, 2022
Merged
13 tasks
tonyhutter pushed a commit that referenced this pull request Mar 19, 2022
@mjguzik @tonyhutter
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
275c756 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes #13219
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@mjguzik @nicman23
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
0675695 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@mjguzik @nicman23
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
70a5aaa 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 2, 2022
@mjguzik @lundman
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
ca7d863 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@mjguzik @beren12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
d417728 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
d7190bf 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
27199c0 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
6e55ec2 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
1455617 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
cdb464d 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
b11a3a6 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
8fd0d5f 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
3625190 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
2eaabaf 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
3ac0f83 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
043d7f2 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
12d846b 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: add missing replay check to an assert in zfs_xvattr_set
05ec243 
Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

@behlendorf behlendorf

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjguzik @behlendorf