Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD: use zero_region instead of allocating a dedicated page #13406

Merged
merged 1 commit into from
May 4, 2022
Merged

FreeBSD: use zero_region instead of allocating a dedicated page #13406

merged 1 commit into from
May 4, 2022

Conversation

mjguzik
Copy link
Contributor

@mjguzik mjguzik commented May 2, 2022

Signed-off-by: Mateusz Guzik mjguzik@gmail.com

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mjguzik
FreeBSD: use zero_region instead of allocating a dedicated page
6aaec1e 
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
@behlendorf behlendorf requested a review from bwatkinson May 2, 2022 23:42
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 2, 2022
@behlendorf behlendorf requested a review from amotin May 2, 2022 23:42
amotin
amotin approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense after the chunk size was fixed to PAGE_SIZE. I was thinking whether it still worth accounting that page in statistics, since the page is not allocated, but I see Linux does the same, so I'm fine with it.

@mjguzik You could ask for the review before committing it to FreeBSD. ;)

amotin
amotin reviewed May 3, 2022
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux actually has two versions of abd_alloc_zero_scatter() -- one for kernel and one for user-space. I guess this version won't build in user-space.

@bwatkinson
Copy link
Contributor

bwatkinson commented May 3, 2022 •
edited
Loading

Linux actually has two versions of abd_alloc_zero_scatter() -- one for kernel and one for user-space. I guess this version won't build in user-space.

This does seem pretty reasonable to me, but @amotin brings up a good point. Would this work with user-space as well? The reason we have both kernel and user-space versions of this in Linux is because abd_get_zeros() is called in vdev_queue_aggregate(), vdev_raidz_map_alloc_write() and vdev_draid_map_alloc_write() for constructing gang ABDs.

@behlendorf
Copy link
Contributor

Currently we always use the Linux version when building in user space. So at least for the moment this not working in user space shouldn't be a problem.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 4, 2022
@behlendorf behlendorf merged commit 81b8b2d into openzfs:master May 4, 2022
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 17, 2022
@mjguzik @behlendorf
FreeBSD: use zero_region instead of allocating a dedicated page
44245b0 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
behlendorf pushed a commit that referenced this pull request May 20, 2022
@mjguzik @behlendorf
FreeBSD: use zero_region instead of allocating a dedicated page
2c5c8bb 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes #13406
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@mjguzik @nicman23
FreeBSD: use zero_region instead of allocating a dedicated page
cbd7f48 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@mjguzik @nicman23
FreeBSD: use zero_region instead of allocating a dedicated page
4189812 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 6, 2022
@mjguzik @lundman
FreeBSD: use zero_region instead of allocating a dedicated page
a800928 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@mjguzik @beren12
FreeBSD: use zero_region instead of allocating a dedicated page
6c30c76 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
4b441f2 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
191a44b 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
f73bcea 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
df07138 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
6227cd1 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
a002168 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
eadfdc9 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
3b197ad 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
d78235f 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
298a2f6 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
97c9a4a 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
4b7ed60 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
f11f50e 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
5afb44a 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
ae34c42 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
6d2593f 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
7b7b7d4 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@mjguzik @andrewc12
FreeBSD: use zero_region instead of allocating a dedicated page
a17ddda 
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@behlendorf behlendorf behlendorf approved these changes

@bwatkinson bwatkinson bwatkinson approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjguzik @bwatkinson @behlendorf @amotin