Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing AC_MSG_RESULT(no) to configure #13454

Merged
merged 1 commit into from
May 12, 2022
Merged

Add missing AC_MSG_RESULT(no) to configure #13454

merged 1 commit into from
May 12, 2022

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Resolve a formatting issue with the ./configure output.

Description

When the HAVE_IOPS_MKDIR_USERNS check fails output the result as required.

How Has This Been Tested?

Before:

checking whether struct shrink_control exists... yes
checking whether iops->mkdir() takes struct user_namespace*... checking whether iops->mkdir() takes umode_t... yes
checking whether iops->lookup() passes flags... yes

After:

checking whether struct shrink_control exists... yes
checking whether iops->mkdir() takes struct user_namespace*... no
checking whether iops->mkdir() takes umode_t... yes
checking whether iops->lookup() passes flags... yes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
Add missing AC_MSG_RESULT(no) to configure
337dff7 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added Type: Building Indicates an issue related to building binaries Status: Code Review Needed Ready for review and testing labels May 11, 2022
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 12, 2022
@behlendorf behlendorf merged commit 45588be into openzfs:master May 12, 2022
behlendorf added a commit to behlendorf/zfs that referenced this pull request May 17, 2022
@behlendorf
Add missing AC_MSG_RESULT(no) to configure
ec92e3c 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
behlendorf added a commit that referenced this pull request May 20, 2022
@behlendorf
Add missing AC_MSG_RESULT(no) to configure
0112bc2 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #13454
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@behlendorf @nicman23
Add missing AC_MSG_RESULT(no) to configure
1c8178f 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@behlendorf @nicman23
Add missing AC_MSG_RESULT(no) to configure
74f543c 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 6, 2022
@behlendorf @lundman
Add missing AC_MSG_RESULT(no) to configure
d443927 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@behlendorf @beren12
Add missing AC_MSG_RESULT(no) to configure
5c2aaef 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
7f4de25 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
23ff3bc 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
50aabe8 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
8a2b539 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
ca4a5bf 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
3eba2e2 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
de92fcd 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
4338154 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
7f5d273 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
7ff689c 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
23815a0 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
c4873ed 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
fbbb114 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
36ebe35 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
b46a7ab 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
f7ff944 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
5cf56e0 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
b861937 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
e986b43 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
d39d3c7 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
5919609 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
707bd8d 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Add missing AC_MSG_RESULT(no) to configure
d83434a 
When the HAVE_IOPS_MKDIR_USERNS check fails output result
as required.
 
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhutter tonyhutter tonyhutter approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @gmelikov @tonyhutter