-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix column width in 'zpool iostat -v' and 'zpool list -v' #13811
Conversation
cc: @akashb-22 would you mind reviewing this followup to your previous PR. |
@npc203 Thanks for noticing this, As I generally use files for testing, I haven't noticed this till now
but, for some cases like when I use smaller vdev names(sd* / nvmeX) with draid as top-level vdev, I see the iostat/list width breaks(ie: enumerated vdev names breaks the column width) like in your case,
With this patch applied, column spacing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to fix the commit message according to style guidelines.
This commit fixes a minor spacing issue caused when enumerating vdev names, which originated from openzfs#13031 Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com>
ffa1c0c
to
c19d64e
Compare
Ah, pardon my ignorance. I was so into fixing the code 80 line length limit, that I skimmed through the commit style check section. Fixed. |
This commit fixes a minor spacing issue caused when enumerating vdev names, which originated from openzfs#13031 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Akash B <akash-b@hpe.com> Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com> Closes openzfs#13811
This commit fixes a minor spacing issue caused when enumerating vdev names, which originated from openzfs#13031 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Akash B <akash-b@hpe.com> Signed-off-by: Samuel Wycliffe <samuelwycliffe@gmail.com> Closes openzfs#13811
This commit fixes a minor spacing issue caused when enumerating vdev names, which originated from #13031
Signed-off-by: Samuel Wycliffe samuelwycliffe@gmail.com
Motivation and Context
The tabular spacing was off by a few characters after enumerating vdev names, in both
zpool iostat -v
andzpool list -v
.This PR fixes it in the same way as it is in
zpool status
as seen hereDescription
Before:
After:
How Has This Been Tested?
As this is a very minor visual change, I've done the changes and compiled it in-tree (using
make cmd
).Manually ran the commands before and after, as shown above.
Types of changes
Checklist:
Signed-off-by
.