Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect free() in zfs_get_pci_slots_sys_path() #13864

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Remove incorrect free() in zfs_get_pci_slots_sys_path() #13864

merged 1 commit into from
Sep 14, 2022

Conversation

ryao
Copy link
Contributor

@ryao ryao commented Sep 9, 2022 •
edited
Loading

Motivation and Context

Coverity found this. We attempted to free tmp, which is a pointer to a string that should be freed by the caller.

Description

We delete the free() call.

How Has This Been Tested?

The buildbot will test it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 12, 2022
@ryao ryao marked this pull request as draft September 13, 2022 01:35
@ryao
Remove incorrect free() in zfs_get_pci_slots_sys_path()
bc6037a 
Coverity found this. We attempted to free tmp, which is a pointer to a
string that should be freed by the caller.

Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
@ryao ryao changed the title Free correct memory in zfs_get_pci_slots_sys_path() Remove incorrect free() in zfs_get_pci_slots_sys_path() Sep 13, 2022
@ryao ryao marked this pull request as ready for review September 13, 2022 13:37
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 13, 2022
@behlendorf behlendorf merged commit fcd7293 into openzfs:master Sep 14, 2022
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@ryao @beren12
Remove incorrect free() in zfs_get_pci_slots_sys_path()
1aaf89f 
Coverity found this. We attempted to free tmp, which is a pointer to a
string that should be freed by the caller.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes openzfs#13864
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 27, 2022
@ryao @andrewc12
Remove incorrect free() in zfs_get_pci_slots_sys_path()
84734d5 
Coverity found this. We attempted to free tmp, which is a pointer to a
string that should be freed by the caller.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes openzfs#13864
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 23, 2022
@ryao @tonyhutter
Remove incorrect free() in zfs_get_pci_slots_sys_path()
e734a61 
Coverity found this. We attempted to free tmp, which is a pointer to a
string that should be freed by the caller.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes openzfs#13864
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 30, 2022
@ryao @tonyhutter
Remove incorrect free() in zfs_get_pci_slots_sys_path()
bddface 
Coverity found this. We attempted to free tmp, which is a pointer to a
string that should be freed by the caller.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes openzfs#13864
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 1, 2022
@ryao @tonyhutter
Remove incorrect free() in zfs_get_pci_slots_sys_path()
3f380df 
Coverity found this. We attempted to free tmp, which is a pointer to a
string that should be freed by the caller.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes openzfs#13864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhutter tonyhutter tonyhutter approved these changes

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryao @behlendorf @Conan-Kudo @tonyhutter