Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire ZFS_TEARDOWN_TRY_ENTER_READ #13906

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Retire ZFS_TEARDOWN_TRY_ENTER_READ #13906

merged 1 commit into from
Sep 20, 2022

Conversation

mjguzik
Copy link
Contributor

@mjguzik mjguzik commented Sep 17, 2022

There were never any users and it so happens the operation is not even supported by rrm locks -- the macros were wrong for Linux and FreeBSD when not using it's RMS locks.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mjguzik
Retire ZFS_TEARDOWN_TRY_ENTER_READ
0514351 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
@mjguzik mjguzik force-pushed the ZFS_TEARDOWN_TRY_ENTER_READ branch from 38dd4d0 to 0514351 Compare September 17, 2022 01:02
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 17, 2022
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 20, 2022
@behlendorf behlendorf merged commit c629f0b into openzfs:master Sep 20, 2022
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 28, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
d540a72 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 28, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
481fa13 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 28, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
30212f0 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
8cecf72 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
4e46cb6 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
c41ebf0 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
d0c8dd9 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
b9fbced 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
1bee496 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
104314c 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
Retire ZFS_TEARDOWN_TRY_ENTER_READ
3ad13e6 
There were never any users and it so happens the operation is not even
supported by rrm locks -- the macros were wrong for Linux and FreeBSD
when not using it's RMS locks.
    
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryao ryao ryao approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjguzik @behlendorf @ryao