Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK #13908

Merged
merged 1 commit into from
Sep 20, 2022
Merged

FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK #13908

merged 1 commit into from
Sep 20, 2022

Conversation

mjguzik
Copy link
Contributor

@mjguzik mjguzik commented Sep 17, 2022

There is an ongoing effort to eliminate this feature.

Signed-off-by: Mateusz Guzik mjguzik@gmail.com

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mjguzik
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
b2ba632 
There is an ongoing effort to eliminate this feature.

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
@behlendorf behlendorf requested review from amotin and a user September 17, 2022 01:26
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 17, 2022
amotin
amotin approved these changes Sep 17, 2022
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not intimate with this area, but if you say so, I have no objections.

ghost
ghost approved these changes Sep 19, 2022 •
edited by ghost
Loading
View reviewed changes
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 20, 2022
@behlendorf behlendorf merged commit 9a671fe into openzfs:master Sep 20, 2022
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 27, 2022
@mjguzik @andrewc12
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
93e4179 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 28, 2022
@mjguzik @andrewc12
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
a27413f 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
ghost pushed a commit to truenas/zfs that referenced this pull request Sep 28, 2022
@mjguzik
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
f305586 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 28, 2022
@mjguzik @tonyhutter
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
2c8e3e4 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
204b1bc 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
41b52cf 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
9535eaa 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
f115a86 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
d965b6a 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
96c6e4c 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@mjguzik @andrewc12
FreeBSD: stop passing LK_INTERLOCK to VOP_LOCK
6fc60a9 
There is an ongoing effort to eliminate this feature.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#13908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjguzik @amotin @behlendorf