-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double declaration of getauxval() for FreeBSD PPC #13936
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryao
approved these changes
Sep 22, 2022
To fix the complete build we need more: in
zfs/include/os/freebsd/spl/sys/simd_powerpc.h Lines 49 to 90 in c629f0b
|
The extern declaration is only for Linux, move this line into the right #ifdef section. Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes: 13934
ghost
approved these changes
Sep 22, 2022
@mmatuska once you're certain this PR is sufficient to resolve the build issue can you please approve it. Then I'll know it's ready to merge. |
@behlendorf I approve the PR, we have it already in FreeBSD base |
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 28, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 28, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Sep 28, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Oct 1, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Oct 1, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Oct 1, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Oct 1, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Oct 1, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Oct 1, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Oct 1, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Oct 1, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Oct 1, 2022
The extern declaration is only for Linux, move this line into the right #ifdef section. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Co-authored-by: Martin Matuska <mm@FreeBSD.org> Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de> Closes openzfs#13934 Closes openzfs#13936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extern declaration is only for Linux, move this line into the right #ifdef section.
Signed-off-by: Tino Reichardt milky-zfs@mcmilk.de
Closes: 13934
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.