Andrew draft pr for buildbot test (do not merge) #13960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewc12
force-pushed
the
andrew_zfsbuildtest
branch
from
988f3f6 to
c67897b
Compare
Unortunately, Windows defines 'long' as 32-bit even on x64 compiles. We create two new macros ZFS_MODULE_LONG and ZFS_MODULE_ULONG. These two will be 'long' on Unix, and let the toolchain handle the size of it. On Windows the two macros are defined as 'int64_t'/'uint64_t'. Clean up source to get Linux builds working (openzfs#119) * Move perfmon functions to windows from zfs_ioctl.h to zfs_ioctl_os.c * remove static for zfs_dirty_data_sync_percent * uint64_t to ZFS_MODULE_ULONG * add ifdef _WIN32 to zvol.c * define posix_memalign_free for other os * add vdev_file_t for other os * remove duplicate check_file * Create build_for_wsl.yaml * move functions to zvol_os.c and add them to the header zvol_impl.h in answer to this discussion openzfsonwindows#119 (comment) * Fix code formatting in reference to openzfsonwindows#119 (comment) * revert the removal of static in dsl_pool.c * remove zfs_dirty_data_sync_percent in dsl_pool.h * make zvol_find_by_name not static * changed workflow name * cstyle zpool_vdev_os.c Fix cstyle complaints (openzfs#125) * clean cstyle * squash * squash * Update zfs_vnops_windows.c * Update zfs_windows_zvol_wmi.c * squash * Additional cstyle fixes * Update sysctl_os.c Upstream: Additional MODULE ULONG Bring per_txg_dirty_frees_percent back to 30 The current value causes significant artificial slowdown during mass parallel file removal, which can be observed both on FreeBSD and Linux when running real workloads. Sample results from Linux doing make -j 96 clean after an allyesconfig modules build: before: 4.14s user 6.79s system 48% cpu 22.631 total after: 4.17s user 6.44s system 153% cpu 6.927 total FreeBSD results in the ticket. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com> Closes openzfs#13932 Closes openzfs#13938 Co-Authored-By: Jorgen Lundman <lundman@lundman.net>
andrewc12
force-pushed
the
andrew_zfsbuildtest
branch
from
f36f0ce to
0cc9066
Compare
This reverts commit 0cc9066. Co-Authored-By: Jorgen Lundman <lundman@lundman.net>
|
Closing, replaced by #14004 which has been merged. |
|
Lol this wasn't meant to closed, I just had it so I could run things against the build bots |
|
Sorry about that, you're welcome to open new PRs to run things against the buildbot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.