Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ambiguity on demand vs prefetch stats reported by arc_summary #13985

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

shodanshok
Copy link
Contributor

@shodanshok shodanshok commented Oct 2, 2022

Motivation and Context

arc_summary currently list prefetch stats as "demand prefetch". For example:

Cache hits by data type:
        Demand data:                                   26.3 %      13.6M
        Demand prefetch data:                           0.6 %     323.5k
        Demand metadata:                               73.1 %      37.9M
        Demand prefetch metadata:                     < 0.1 %      15.0k

Cache misses by data type:
        Demand data:                                   65.9 %       1.1M
        Demand prefetch data:                          31.2 %     534.2k
        Demand metadata:                                1.2 %      20.8k
        Demand prefetch metadata:                       1.7 %      28.6k

However, a hit/miss can be due to demand or prefetch, not both at the same time.
This commit clearly marks prefetched data/metadata as such, by removing "Demand" from the line.

Description

The commit is extremely simple, and only affects the arc_summary file in how it prints four rows.

How Has This Been Tested?

On a local machine with the commit applied, arc_summary correctly show the following:

Cache hits by data type:
        Demand data:                                   26.3 %      13.6M
        Prefetch data:                                  0.6 %     323.5k
        Demand metadata:                               73.1 %      37.9M
        Prefetch metadata:                            < 0.1 %      15.0k

Cache misses by data type:
        Demand data:                                   65.9 %       1.1M
        Prefetch data:                                 31.2 %     534.2k
        Demand metadata:                                1.2 %      20.8k
        Prefetch metadata:                              1.7 %      28.6k

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

arc_summary currently list prefetch stats as "demand prefetch"
However, a hit/miss can be due to demand or prefetch, not both.
To remove any confusion, this patch removes the "Demand" word
from the affected lines.

Signed-off-by: Gionatan Danti <g.danti@assyoma.it>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 4, 2022
@behlendorf behlendorf merged commit 062d3d0 into openzfs:master Oct 4, 2022
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 4, 2022
arc_summary currently list prefetch stats as "demand prefetch"
However, a hit/miss can be due to demand or prefetch, not both.
To remove any confusion, this patch removes the "Demand" word
from the affected lines.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Gionatan Danti <g.danti@assyoma.it>
Closes openzfs#13985
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 6, 2022
arc_summary currently list prefetch stats as "demand prefetch"
However, a hit/miss can be due to demand or prefetch, not both.
To remove any confusion, this patch removes the "Demand" word
from the affected lines.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Gionatan Danti <g.danti@assyoma.it>
Closes openzfs#13985
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 6, 2022
arc_summary currently list prefetch stats as "demand prefetch"
However, a hit/miss can be due to demand or prefetch, not both.
To remove any confusion, this patch removes the "Demand" word
from the affected lines.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Gionatan Danti <g.danti@assyoma.it>
Closes openzfs#13985
behlendorf pushed a commit that referenced this pull request Nov 1, 2022
arc_summary currently list prefetch stats as "demand prefetch"
However, a hit/miss can be due to demand or prefetch, not both.
To remove any confusion, this patch removes the "Demand" word
from the affected lines.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Gionatan Danti <g.danti@assyoma.it>
Closes #13985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants