FreeBSD: Remove stray debug printf #14287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Dec 13, 2022
amotin
reviewed
Dec 13, 2022
Fixes openzfs#14286. Signed-off-by: Doug Rabson <dfr@rabson.org>
amotin
approved these changes
Dec 13, 2022
ryao
reviewed
Dec 13, 2022
ghost
approved these changes
Dec 13, 2022
ryao
approved these changes
Dec 13, 2022
ghost
added
the
13 tasks
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Dec 18, 2022
Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Doug Rabson <dfr@rabson.org> Closes openzfs#14286 Closes openzfs#14287
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 13, 2023
Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Doug Rabson <dfr@rabson.org> Closes openzfs#14286 Closes openzfs#14287
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 18, 2023
Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Doug Rabson <dfr@rabson.org> Closes openzfs#14286 Closes openzfs#14287
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 19, 2023
Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: Doug Rabson <dfr@rabson.org> Closes openzfs#14286 Closes openzfs#14287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14286.
Signed-off-by: Doug Rabson dfr@rabson.org
Motivation and Context
This removes a cryptic console printf generated when an application tries to set non-blocking i/o on a /dev/zfs file descriptor. See #14284 for a little more context.
Description
This change simply removes the printf.
How Has This Been Tested?
Built a recent FreeBSD-14-current kernel with this change and verified that the application triggering this printf no longer causes console logging side effects.
Types of changes
Checklist:
Signed-off-by.