Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix data race between zil_commit() and zil_suspend()" #14790

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Revert "Fix data race between zil_commit() and zil_suspend()" #14790

merged 1 commit into from
Apr 25, 2023

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

#14775

Description

This reverts commit 4c856fb to resolve a newly introduced deadlock which in practice is more disruptive that the issue this commit intended to address.

How Has This Been Tested?

Reverts to the original code. The intent is to run this through the CI multiple times and verify the deadlock this is believed to have introduced does not occur after the revert.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
Revert "Fix data race between zil_commit() and zil_suspend()"
34738ae 
This reverts commit 4c856fb to
resolve a newly introduced deadlock which in practice in more
disruptive that the issue this commit intended to address.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 25, 2023
@behlendorf behlendorf requested a review from ryao April 25, 2023 00:11
@behlendorf behlendorf mentioned this pull request Apr 25, 2023
Open
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 25, 2023
@behlendorf behlendorf merged commit 0e8a42b into openzfs:master Apr 25, 2023
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request May 1, 2023
@behlendorf @andrewc12
Revert "Fix data race between zil_commit() and zil_suspend()"
702c144 
This reverts commit 4c856fb to
resolve a newly introduced deadlock which in practice in more
disruptive that the issue this commit intended to address.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Mark Maybee <mark.maybee@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#14775
Closes openzfs#14790
@amotin amotin mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaybee mmaybee mmaybee approved these changes

@ryao ryao ryao approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @ryao @mmaybee