Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix positive ABD size assertion in abd_verify() #14795

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix positive ABD size assertion in abd_verify() #14795

merged 1 commit into from
Apr 26, 2023

Conversation

amotin
Copy link
Member

@amotin amotin commented Apr 25, 2023

Gang ABDs without childred are legal, and they do have zero size. For other ABD types zero size doesn't have much sense and likely not working correctly now.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Fix positive ABD size assertion in abd_verify().
d0102cd 
Gang ABDs without childred are legal, and they do have zero size.
For other ABD types zero size doesn't have much sense and likely
not working correctly now.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Apr 25, 2023
@behlendorf behlendorf requested a review from bwatkinson April 25, 2023 23:02
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 25, 2023
@behlendorf behlendorf merged commit bba7cbf into openzfs:master Apr 26, 2023
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request May 1, 2023
@amotin @andrewc12
Fix positive ABD size assertion in abd_verify().
1f898b8 
Gang ABDs without childred are legal, and they do have zero size.
For other ABD types zero size doesn't have much sense and likely
not working correctly now.

Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#14795
amotin added a commit to amotin/zfs that referenced this pull request Jun 2, 2023
@amotin
Fix positive ABD size assertion in abd_verify().
38da653 
Gang ABDs without childred are legal, and they do have zero size.
For other ABD types zero size doesn't have much sense and likely
not working correctly now.

Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#14795
behlendorf pushed a commit that referenced this pull request Jun 2, 2023
@amotin @behlendorf
Fix positive ABD size assertion in abd_verify().
e271cd7 
Gang ABDs without childred are legal, and they do have zero size.
For other ABD types zero size doesn't have much sense and likely
not working correctly now.

Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes #14795
@amotin amotin deleted the abd_size branch October 9, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikozhukhov ikozhukhov ikozhukhov approved these changes

@behlendorf behlendorf behlendorf approved these changes

@bwatkinson bwatkinson Awaiting requested review from bwatkinson

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amotin @behlendorf @ikozhukhov