Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkstyle warning #14799

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix checkstyle warning #14799

merged 1 commit into from
Apr 26, 2023

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Keep the code clean.

Description

Resolve a checkstyle warning I accidentally overlooked when merging e37a89d.

How Has This Been Tested?

make checkstyle

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
Fix checkstyle warning
17052fd 
Resolve a missed checkstyle warning.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 26, 2023
@mjguzik
Copy link
Contributor

mjguzik commented Apr 26, 2023 •
edited
Loading

<half-assed apologies go here> :)

amotin
amotin approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never understood this style requirement applied to sizeof(), but it is better to have the check working.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 26, 2023
@behlendorf
Copy link
Contributor Author

Thanks, I'll merge this as soon as checkstyle gives us a clean bill of health.

@behlendorf behlendorf merged commit b541161 into openzfs:master Apr 26, 2023
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request May 1, 2023
@behlendorf @andrewc12
Fix checkstyle warning
129da10 
Resolve a missed checkstyle warning.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#14799
behlendorf added a commit to behlendorf/zfs that referenced this pull request May 26, 2023
@behlendorf
Fix checkstyle warning
d7ff250 
Resolve a missed checkstyle warning.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#14799
behlendorf added a commit to behlendorf/zfs that referenced this pull request May 28, 2023
@behlendorf
Fix checkstyle warning
44c50e3 
Resolve a missed checkstyle warning.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#14799
behlendorf added a commit that referenced this pull request May 30, 2023
@behlendorf
Fix checkstyle warning
45c4b3e 
Resolve a missed checkstyle warning.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #14799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@amotin amotin amotin approved these changes

@mjguzik mjguzik mjguzik approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@behlendorf @mjguzik @gmelikov @amotin